[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Re: Review Request 110059: Consistent behaviour of wordNext()
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-05-03 8:14:31
Message-ID: 2462905.hMypkft6sG () obiwan
[Download RAW message or body]

On Wednesday, April 17, 2013 14:22:06 Dominik Haumann wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110059/#review31216
> -----------------------------------------------------------
> 
> 
> This indeed is a question of consistency: Currently Kate behavies like
> KMail's composer, like a QLineEdit and QTextEdit except that it ignore
> line-breaks. The behavior currently is such that the cursor of nextWord
> (=ctrl+right arrow) stops of exactly the same positions as prevWord
> (=ctrl+prev arrow). So the code is kind of mirrored, yielding a consistent
> way of cursor navigation.
> 
> The patch itself is fine, it's just a matter of taste. Other comments?

Meanwhile, I've rejected the patch. And in fact, after having tested it for
about two weeks, it introduces several regressions. An example is this:
text |               text
If you press ctrl+del, we get the following with the old behavior:
text |text

With patch, we get
text |

That is, the word is also deleted. Therefore, with the patch, you always
have to delete spaces to the next word by hand. Imo, this is not acceptable ;)

We don't really have to discuss this further though. It's been decided.

Greetings,
Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]