'Re: [kate] part: 45% merge between stuff imported from kdevelop and the snippets_tng plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate] part: 45% merge between stuff imported from kdevelop and the snippets_tng plugin
From:       "Joseph Wenninger" <jowenn () kde ! org>
Date:       2013-04-26 9:17:58
Message-ID: 5598c6f07a2e1b0aa0ab6fca80336397.squirrel () mail0809 ! jowenn ! net
[Download RAW message or body]

That particular crash should be fixed now

> On Wednesday, 24. April 2013 10:20:10 Joseph Wenninger wrote:
>> Do you have the plugin enabled also?
>> Do you have snippets enabled/disabled?
>> What kinds of documents do you have?
>> Could you send in a PM the terminal output before the crash?
>
> Others have it, too: https://bugs.kde.org/show_bug.cgi?id=318811
>
>
>> Thanks
>> Joseph
>>
>> > Since your snippet commits, there also is the following crash in the
>> > config
>> > dialog, see backtrace below.
>> >
>> > Please fix it :( If it's not fixed by 1st of June  (5th of June is
>> string
>> > freeze [1]), I'll revert all the snippet commits again according to
>> the
>> > schedules on techbase so we at least have a stable Kate for KDE 4.11.
>> >
>> > [1] http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule
>> >
>> > Thanks
>> >
>> > Thread 1 (Thread 0xb49f9740 (LWP 6077)):
>> > [KCrash Handler]
>> > #6  0xb3118ab7 in qobject_cast<KTextEditor::CodeCompletionInterface*>
>> > (object=0x83) at kate/ktexteditor/codecompletioninterface.h:152
>> > #7  0xb3287282 in KateSnippetGlobal::removeDocument
>> > (this=this@entry=0x99fd1f8, document=0xa74e0e8) at
>> > kate/part/snippet/katesnippetglobal.cpp:271
>> > #8  0xb3288005 in KateSnippetGlobal::slotTypeChanged
>> > (this=this@entry=0x99fd1f8, fileType=...) at
>> > kate/part/snippet/katesnippetglobal.cpp:333
>> > #9  0xb328837d in KateSnippetGlobal::internalUpdateSessionConfig
>> > (this=0x99fd1f8) at kate/part/snippet/katesnippetglobal.cpp:85
>> > #10 0xb328dddc in KatePartSnippetsConfigPage::apply (this=0xbc48c60)
>> at
>> > kate/part/snippet/repositoryview.cpp:65
>> > #11 0xb76c4ffd in KateConfigDialog::slotApply
>> (this=this@entry=0xb91bbc8)
>> > at kate/kate/app/kateconfigdialog.cpp:363
>> > #12 0xb76c5040 in KateConfigDialog::slotOk (this=0xb91bbc8) at
>> > kate/kate/app/kateconfigdialog.cpp:309
>> > #13 0xb5b8f9d2 in QMetaObject::activate (sender=0xb91bbc8,
>> m=0xb70c2490
>> > <KDialog::staticMetaObject>, local_signal_index=9, argv=0x0) at
>> > kernel/qobject.cpp:3548
>> > #14 0xb6dcac85 in KDialog::okClicked() () from /usr/lib/libkdeui.so.5
>> > #15 0xb6dcb4a0 in KDialog::slotButtonClicked(int) () from
>> > /usr/lib/libkdeui.so.5
>> > #16 0xb6dcb9f4 in ?? () from /usr/lib/libkdeui.so.5
>> > #17 0xb5b8f9d2 in QMetaObject::activate (sender=0xbd653e4,
>> m=0xb5ce0df8
>> > <QSignalMapper::staticMetaObject>, local_signal_index=0,
>> argv=0xbffef8a8)
>> > at kernel/qobject.cpp:3548
>> > #18 0xb5b94c75 in QSignalMapper::mapped (this=this@entry=0xbd653e4,
>> _t1=4)
>> > at .moc/release-shared/moc_qsignalmapper.cpp:115
>> > #19 0xb5b94ebd in QSignalMapper::map (this=this@entry=0xbd653e4,
>> > sender=0xbb73f38) at kernel/qsignalmapper.cpp:266
>> > #20 0xb5b94fce in QSignalMapper::map (this=this@entry=0xbd653e4) at
>> > kernel/qsignalmapper.cpp:257
>> > #21 0xb5b95424 in qt_static_metacall (_a=0xbffefa38, _id=4,
>> _o=0xbd653e4,
>> > _c=<optimized out>) at .moc/release-shared/moc_qsignalmapper.cpp:64
>> > #22 QSignalMapper::qt_static_metacall (_o=_o@entry=0xbd653e4,
>> > _c=_c@entry=QMetaObject::InvokeMetaMethod, _id=_id@entry=4,
>> _a=0xbffefa38)
>> > at .moc/release-shared/moc_qsignalmapper.cpp:54
>> > #23 0xb5b8f9d2 in QMetaObject::activate (sender=0xbb73f38,
>> m=0xb6c7f888
>> > <QAbstractButton::staticMetaObject>, local_signal_index=2,
>> > argv=0xbffefa38) at kernel/qobject.cpp:3548
>> > #24 0xb6a11cfd in QAbstractButton::clicked(bool) () from
>> > /usr/lib/libQtGui.so.4
>> > #25 0xb6715d5d in ?? () from /usr/lib/libQtGui.so.4
>> > #26 0xb67165ab in ?? () from /usr/lib/libQtGui.so.4
>> > #27 0xb6716866 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
>> from
>> > /usr/lib/libQtGui.so.4
>> > #28 0xb63508c4 in QWidget::event(QEvent*) () from
>> /usr/lib/libQtGui.so.4
>> > #29 0xb6715c22 in QAbstractButton::event(QEvent*) () from
>> > /usr/lib/libQtGui.so.4
>> > #30 0xb67b7828 in QPushButton::event(QEvent*) () from
>> > /usr/lib/libQtGui.so.4
>> > #31 0xb62f6b9c in QApplicationPrivate::notify_helper(QObject*,
>> QEvent*) ()
>> > from /usr/lib/libQtGui.so.4
>> > #32 0xb62fc089 in QApplication::notify(QObject*, QEvent*) () from
>> > /usr/lib/libQtGui.so.4
>> > #33 0xb6e800f1 in KApplication::notify(QObject*, QEvent*) () from
>> > /usr/lib/libkdeui.so.5
>> > #34 0xb5b7767e in QCoreApplication::notifyInternal (this=0xbfff1d5c,
>> > receiver=0xbb73f38, event=0xbfff0154) at
>> kernel/qcoreapplication.cpp:946
>> > #35 0xb62f79ff in QApplicationPrivate::sendMouseEvent(QWidget*,
>> > QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool)
>> ()
>> > from /usr/lib/libQtGui.so.4
>> > #36 0xb6380145 in ?? () from /usr/lib/libQtGui.so.4
>> > #37 0xb637ec09 in QApplication::x11ProcessEvent(_XEvent*) () from
>> > /usr/lib/libQtGui.so.4
>> > #38 0xb63a88a4 in ?? () from /usr/lib/libQtGui.so.4
>> > #39 0xb4ead7d3 in g_main_context_dispatch () from
>> > /usr/lib/libglib-2.0.so.0
>> > #40 0xb4eadb70 in ?? () from /usr/lib/libglib-2.0.so.0
>> > #41 0xb4eadc51 in g_main_context_iteration () from
>> > /usr/lib/libglib-2.0.so.0
>> > #42 0xb5ba966f in QEventDispatcherGlib::processEvents (this=0x96782f8,
>> > flags=...) at kernel/qeventdispatcher_glib.cpp:426
>> > #43 0xb63a848a in ?? () from /usr/lib/libQtGui.so.4
>> > #44 0xb5b7614c in QEventLoop::processEvents
>> (this=this@entry=0xbfff0878,
>> > flags=...) at kernel/qeventloop.cpp:149
>> > #45 0xb5b76441 in QEventLoop::exec (this=0xbfff0878, flags=...) at
>> > kernel/qeventloop.cpp:204
>> > #46 0xb683715d in QDialog::exec() () from /usr/lib/libQtGui.so.4
>> > #47 0xb76d0d24 in KateMainWindow::showPluginConfigPage
>> > (this=this@entry=0x9a1f518,
>> > configpageinterface=configpageinterface@entry=0x0, id=id@entry=0) at
>> > kate/kate/app/katemainwindow.cpp:719
>> > #48 0xb76d0d6f in KateMainWindow::slotConfigure
>> > (this=this@entry=0x9a1f518) at kate/kate/app/katemainwindow.cpp:707
>> >
>> > On Sunday, 21. April 2013 13:18:57 Dominik Haumann wrote:
>> >> Hi,
>> >>
>> >> On Saturday, 20. April 2013 21:13:53 Joseph Wenninger wrote:
>> >> > -  return snippetGlobal()->snippetWidget ();
>> >> > +#warning FIXME
>> >> > +  return snippetGlobal()->snippetWidget (0,(KateView*)0);
>> >>
>> >> do you really think this FIXME will help us in the next years?
>> Usually
>> >> these
>> >> kind of fixmes stay there for years. Can you please fix it
>> immediately?
>> >> It
>> >> doesn't even say what needs to be fixed...
>> >>
>> >> Exactly the same holds for the FIXME in KateGlobal::snippedWidget().
>> >>
>> >> Besides, it won't compile on Windows. This also applies to the 10
>> other
>> >> #warning directives in snippetview.cpp...
>> >>
>> >>
>> >> Next, according to
>> >> http://build.kde.org/job/kate_master/765/warnings15Result/? the
>> compiler
>> >> warnings went up from 14 to 56, so your commits introduce 42 new
>> >> compiler
>> >> warnings.
>> >>
>> >> Can we agree that new commits should add no new compiler warnings at
>> >> all?
>> >>
>> >>
>> >> Next one: I'd personally welcome it we could at least quickly discuss
>> >> KTextEditor interface changes (the isOrphaned() stuff). Especially
>> since
>> >> KTE
>> >> is considered pretty much frozen for KDE4.
>> >>
>> >> Thank you...
>> >>
>> >> Dominik
>> >> _______________________________________________
>> >> KWrite-Devel mailing list
>> >> KWrite-Devel@kde.org
>> >> https://mail.kde.org/mailman/listinfo/kwrite-devel
>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread] 