[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate] kate/app: New Signal: viewChanged(view)
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-04-23 19:26:27
Message-ID: 2959753.pxzIRBIFXk () eriador
[Download RAW message or body]

On Saturday, 20. April 2013 21:13:53 Joseph Wenninger wrote:
> Git commit 93fe9be986bced7c62e05a5ba592798522c39dbe by Joseph Wenninger.
> Committed on 12/11/2012 at 13:09.
> Pushed by jowenn into branch 'master'.
> 
> New Signal: viewChanged(view)

And why is the signal needed? Now we have two signals doing the same:
>      void viewChanged ();
> +    void viewChanged (KTextEditor::View *);

There are two better solutions to the same singal twice:
1) just ust KateViewManager::activeView() to get the active view in your code
2) remove viewChanged() in favor of viewChanged(view) and fix all the code.

But this is a hack, which I obviously dislike. Can you fix it properly, 
please?

Thanks



> M  +2    -0    kate/app/kateviewmanager.cpp
> M  +1    -0    kate/app/kateviewmanager.h
> 
> http://commits.kde.org/kate/93fe9be986bced7c62e05a5ba592798522c39dbe
> 
> diff --git a/kate/app/kateviewmanager.cpp b/kate/app/kateviewmanager.cpp
> index 2dbd1f9..3e1f744 100644
> --- a/kate/app/kateviewmanager.cpp
> +++ b/kate/app/kateviewmanager.cpp
> @@ -604,6 +604,7 @@ void KateViewManager::activateView ( KTextEditor::View
> *view ) m_lruViews[view] = m_minAge--;
> 
>      emit viewChanged();
> +    emit viewChanged(view);
>    }
>  }
> 
> @@ -811,6 +812,7 @@ void KateViewManager::removeViewSpace (KateViewSpace
> *viewspace) updateViewSpaceActions ();
> 
>    emit viewChanged();
> +  emit viewChanged(v);
>  }
> 
>  void KateViewManager::slotCloseCurrentViewSpace()
> diff --git a/kate/app/kateviewmanager.h b/kate/app/kateviewmanager.h
> index 1c84e9b..c914872 100644
> --- a/kate/app/kateviewmanager.h
> +++ b/kate/app/kateviewmanager.h
> @@ -124,6 +124,7 @@ class KateViewManager : public QSplitter
>    Q_SIGNALS:
>      void statChanged ();
>      void viewChanged ();
> +    void viewChanged (KTextEditor::View *);
>      void viewCreated (KTextEditor::View *);
> 
>      void cursorPositionItemVisibilityChanged(bool);
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]