[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Re: [kate] part/document: add "New file" message for locally non-existing files
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-04-22 7:18:37
Message-ID: 1513435.NdkCMOh1AE () obiwan
[Download RAW message or body]

On Thursday, April 18, 2013 12:13:33 Matthew Woehlke wrote:
> On 2013-04-18 04:39, Dominik Haumann wrote:
> > On Wednesday, April 17, 2013 18:59:16 Matthew Woehlke wrote:
> >> I see KMessageWidget is using the highlighted set for information... the
> >> link role would probably be better (should provide more consistent
> >> contrast, anyway).
> > 
> > No, they use KColorScheme:
> > http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/kmessagewidget_8cpp
> > .html#a9bc665502b753a859f77895cf364f831
> ...except for Information; see kdeui/wisgets/kmessagewidget.cpp circa
> lines (in master) 261-267 (or
> http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/kmessagewidget_8cpp_s
> ource.html#l00262).
> 
> It is surprising that this is inadequate contrast, since that would
> imply that selection anywhere has inadequate contrast...
> 
> Anyway, I still think using link background instead might be more
> consistent :-).

Ok, you're correct. Then let me simply remove my argument of contrast ;)

Greetings,
Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]