[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request 110067: Make gui string + icon to open handbook from dialog consistent with other hel
From:       Burkhard_Lück <lueck () hube-lueck ! de>
Date:       2013-04-17 19:39:57
Message-ID: 20130417193957.5763.22141 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110067/
-----------------------------------------------------------

Review request for Kate and Joseph Wenninger.


Description
-------

1) Currently the button string ("Show Documentation") and icon ("help-about") 
   in the dialog are different from the default used everywhere in kde dialogs,
   so changed that to the default values to make it consistent
2) fix wrong anchor in handbook


Diffs
-----

  part/snippet/editsnippet.cpp 08c6de0 

Diff: http://git.reviewboard.kde.org/r/110067/diff/


Testing
-------


Thanks,

Burkhard Lück


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110067/">http://git.reviewboard.kde.org/r/110067/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Kate and Joseph Wenninger.</div>
<div>By Burkhard Lück.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Currently the button string (&quot;Show \
Documentation&quot;) and icon (&quot;help-about&quot;)   in the dialog are \
different from the default used everywhere in kde dialogs,  so changed that \
to the default values to make it consistent 2) fix wrong anchor in \
handbook</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/snippet/editsnippet.cpp <span style="color: \
grey">(08c6de0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110067/diff/" \
style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic