[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 109366: RFC: Change tab order in search & replace
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2013-04-11 8:26:46
Message-ID: 20130411082646.16951.57883 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109366/
-----------------------------------------------------------
(Updated April 11, 2013, 8:26 a.m.)
Status
------
This change has been discarded.
Review request for Kate and Kåre Särs.
Description
-------
Using the search&replace plugin with just the keyboard is still a bit tedious.
After typing in the search term, it takes a lot of tabs to get to the folders- and \
include- and exclude filter line edits, due to the focus going through 6 other \
widgets in between where the focus is (at least here with Oxygen) almost invisible. \
The attached path changes the tab order so that it goes first through all the combo \
boxes, and afterwards through the other widgets. This makes entering input into the \
combo boxes much faster. OTOH it changes the tab order to something slightly \
unexpected maybe.
Another option would be to set focus policy to ClickFocus for the three checkboxes \
under the search combo box.
How are actually the shortcuts for the checkboxes assigned ?
I get an M for "Match case", an "x" for "Expand results" and none for "Regular \
expression". It would be really good if all checkboxes had shortcuts.
Diffs
-----
kate/plugins/search/search.ui 285544a
Diff: http://git.reviewboard.kde.org/r/109366/diff/
Testing
-------
Thanks,
Alexander Neundorf
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109366/">http://git.reviewboard.kde.org/r/109366/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Kåre Särs.</div>
<div>By Alexander Neundorf.</div>
<p style="color: grey;"><i>Updated April 11, 2013, 8:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using the search&replace plugin with just the keyboard is still a \
bit tedious. After typing in the search term, it takes a lot of tabs to get to the \
folders- and include- and exclude filter line edits, due to the focus going through 6 \
other widgets in between where the focus is (at least here with Oxygen) almost \
invisible. The attached path changes the tab order so that it goes first through all \
the combo boxes, and afterwards through the other widgets. This makes entering input \
into the combo boxes much faster. OTOH it changes the tab order to something slightly \
unexpected maybe.
Another option would be to set focus policy to ClickFocus for the three checkboxes \
under the search combo box.
How are actually the shortcuts for the checkboxes assigned ?
I get an M for "Match case", an "x" for "Expand \
results" and none for "Regular expression". It would be really good if \
all checkboxes had shortcuts. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/search/search.ui <span style="color: grey">(285544a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109366/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic