[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Somebody to review this?
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2013-04-10 21:45:16
Message-ID: CAHAc2jcQbeBy6hc2eynNRY2W=pMvEVnnLk6c5N7APHFMj=VoLA () mail ! gmail ! com
[Download RAW message or body]

Fair enough, just thought I'd check :-)

On 10 April 2013 18:46, Philipp A. <flying-sheep@web.de> wrote:
> hi, this is correct.
>
> someone told me not to do as much code duplication, and the only way to do
> this was creating a intermediate class between
> KTextEditor.CodeCompletionModel and
> libkatepate.autocomplete.AbstractCodeCompletionModel that doesn't make as
> much assumptions as the latter. the changes to that file simply involve
> moving many methods of AbstractCodeCompletionModel to that new intermediate
> class. i also added comments and prettified the code, which made the diff
> not reflect the refactoring nature this change properly.
>
> i also added an useful fuction to libkatepate.ui that i found useful in
> order to to debug many enum-containing Qt classes in the past. i think it's
> useful for more people, so i left it in, but i can take it out or file a
> separate request for it if you want.
>
> the current diff is v5 :) https://git.reviewboard.kde.org/r/109326/diff/5/
>
>
> 2013/4/10 J. Pablo Martín Cobos <goinnn@gmail.com>
>
>> I don't know.....
>>
>> El 09/04/2013 23:29, "Shaheed Haque" <srhaque@theiet.org> escribió:
>>
>>> Is this commit really changing all these files? Or has something gone
>>> badly wrong?
>>>
>>> On 9 April 2013 09:37, J. Pablo Martín Cobos <goinnn@gmail.com> wrote:
>>> > https://git.reviewboard.kde.org/r/109326/diff/2/
>>> >
>>> > I don't understand why is is related with added jedi-autocomplete [1],
>>> > I
>>> > suppose that is an error.
>>> >
>>> > REF's:
>>> >
>>> > 1. https://git.reviewboard.kde.org/r/109326
>>> >
>>> >
>>> > Best Regards,
>>> >
>>> > --
>>> >
>>> > Pablo Martín
>>> >
>>> >
>>> > _______________________________________________
>>> > KWrite-Devel mailing list
>>> > KWrite-Devel@kde.org
>>> > https://mail.kde.org/mailman/listinfo/kwrite-devel
>>> >
>>> _______________________________________________
>>> KWrite-Devel mailing list
>>> KWrite-Devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>
>>
>> _______________________________________________
>> KWrite-Devel mailing list
>> KWrite-Devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>
>
>
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread]