[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: finding where all the auto highlight and the DeleteLine function is
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-03-19 19:18:37
Message-ID: 3564650.ICJEX9kqCs () eriador
[Download RAW message or body]

On Tuesday, 19. March 2013 15:54:32 Mayank Jha wrote:
> I thought that what Dominik implied is that we need to use editStart and
> editEnd instead of using the condition to check selection().?? I could not
> get the generic implementation part? dominik clarified that part I guess?

The correct fix is to not touch killLines at all.
Instead, implement the emission of the signal in KateView::editEnd, and remove 
all other emits in kateview. Maybe this is not as trivial as thought to fix, 
but fixing it just for one action will not work for the next action that is 
added. That said, unfortunately both patches on reviewboard are wrong.

Greetings,
Dominik

> On Tue, Mar 19, 2013 at 3:44 PM, Miquel Canes <miquelcanes@gmail.com> wrote:
> > As I understand, m_selection should be compared in editEnd with the
> > original selection, if m_selection changed then emit the signal. Using
> > editStart and EditEnd in the killLine method is not the generic
> > implementation that is commented on the review request.
> > 
> > I don't know if you can merge the request in another review.
> > 
> > Greetings
> > 
> > On Tue, Mar 19, 2013 at 10:55 AM, Mayank Jha 
<mayank25080562@gmail.com>wrote:
> >> Hello Miquel,
> >> I took a look at it, and also Dominik and Christoph's comment. As dominik
> >> told we need to reimplement this with the help of editStart and editEnd
> >> methods, which I did in my review request. Can I merge this request with
> >> yours? Is there a way to do so?
> >> 
> >> On Tue, Mar 19, 2013 at 3:16 PM, Miquel Canes 
<miquelcanes@gmail.com>wrote:
> >>> Hi Mayank,
> >>> I has been working on this bug too.
> >>> In this review https://git.reviewboard.kde.org/r/109553/ Dominik and
> >>> Christoph comment about how should be fixed.
> >>> Maybe you can take a look and fix it.
> >>> 
> >>> Greetings
> >>> 
> >>> On Tue, Mar 19, 2013 at 10:25 AM, Mayank Jha 
<mayank25080562@gmail.com>wrote:
> >>>> is this patch fine? https://git.reviewboard.kde.org/r/109579/
> >>>> 
> >>>> On Tue, Mar 19, 2013 at 12:23 PM, Dominik Haumann 
<dhaumann@kde.org>wrote:
> >>>>> On Monday, March 18, 2013 21:02:22 Mayank Jha wrote:
> >>>>> > In relation to the https://bugs.kde.org/show_bug.cgi?id=316226 I
> >>>>> 
> >>>>> was trying
> >>>>> 
> >>>>> > to locate the exact place which is responsible for the functionn
> >>>>> 
> >>>>> definition
> >>>>> 
> >>>>> > wherein the DeleteLine function corresponding to the default
> >>>>> > shortcut
> >>>>> > Ctrl+K is located. All active developers of Kate please help!
> >>>>> 
> >>>>> Uhm, please search for "Qt::Key_K" in the Kate code base.
> >>>>> Hint: it's in kateview.cpp.
> >>>>> 
> >>>>> Greetings
> >>>>> Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]