[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 109553: emit KateView::selectionChanged() when a line is "killed"
From: "mayank jha" <mjnovice () gmail ! com>
Date: 2013-03-19 10:23:40
Message-ID: 20130319102340.20270.91524 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 18, 2013, 9:08 p.m., Christoph Cullmann wrote:
> > Hi, guess that is no real fix, sorry.
> > editEnd needs to ensure that if any selected lines are touched, the signal should \
> > be emitted,I guess it must be fixed there instead for all editing primitives.
>
> Miquel Canes Gonzalez wrote:
> In other words, emit the signal from the KateDocument to the actual active KateView \
> if any selected line is changed? Is it correct?
> Dominik Haumann wrote:
> KateDocument::endEdit() already calls KateView::editEnd() for each view, which is \
> propagated to KateViewInternal. emit selectionChanged() is only called in KateView, \
> though. In fact, it's only called in \
> KateView::setSelection/clearSelection/setBlockSelectionMode. In other words, \
> currently it *is* called through user actions in KateView. So the patch is not that \
> wrong.
> Still, the proper fix would be to compare the text selection in editEnd with the \
> one in editStart I guess?
I think that this should be what you are talking about? \
https://git.reviewboard.kde.org/r/109579/
- mayank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109553/#review29476
-----------------------------------------------------------
On March 18, 2013, 8:03 p.m., Miquel Canes Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109553/
> -----------------------------------------------------------
>
> (Updated March 18, 2013, 8:03 p.m.)
>
>
> Review request for Kate.
>
>
> Description
> -------
>
> Emit selection changed when a line is killed.
>
>
> Another implementation can be call clearSelection for the active view of the \
> document when a line is removed. But I don't know how the removeLine method is \
> used. Can be called to remove a line that is not the actual.
>
> This addresses bug 316226.
> http://bugs.kde.org/show_bug.cgi?id=316226
>
>
> Diffs
> -----
>
> part/view/kateview.cpp cf9ccb0
>
> Diff: http://git.reviewboard.kde.org/r/109553/diff/
>
>
> Testing
> -------
>
> see bug.
>
>
> Thanks,
>
> Miquel Canes Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109553/">http://git.reviewboard.kde.org/r/109553/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 18th, 2013, 9:08 p.m. UTC, <b>Christoph \
Cullmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, guess that is no real fix, sorry. editEnd needs to ensure that if \
any selected lines are touched, the signal should be emitted,I guess it must be fixed \
there instead for all editing primitives.</pre> </blockquote>
<p>On March 18th, 2013, 9:26 p.m. UTC, <b>Miquel Canes Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In other words, emit the \
signal from the KateDocument to the actual active KateView if any selected line is \
changed? Is it correct?</pre> </blockquote>
<p>On March 19th, 2013, 6:32 a.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KateDocument::endEdit() \
already calls KateView::editEnd() for each view, which is propagated to \
KateViewInternal. emit selectionChanged() is only called in KateView, though. In \
fact, it's only called in \
KateView::setSelection/clearSelection/setBlockSelectionMode. In other words, \
currently it *is* called through user actions in KateView. So the patch is not that \
wrong.
Still, the proper fix would be to compare the text selection in editEnd with the one \
in editStart I guess?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that this should \
be what you are talking about? https://git.reviewboard.kde.org/r/109579/</pre> <br />
<p>- mayank</p>
<br />
<p>On March 18th, 2013, 8:03 p.m. UTC, Miquel Canes Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Miquel Canes Gonzalez.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 8:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Emit selection changed when a line is killed.
Another implementation can be call clearSelection for the active view of the document \
when a line is removed. But I don't know how the removeLine method is used. Can \
be called to remove a line that is not the actual. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see bug.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316226">316226</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/view/kateview.cpp <span style="color: grey">(cf9ccb0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109553/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic