[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 109058: Projects plugin: add git tools to context menu
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2013-02-20 20:04:18
Message-ID: 20130220200418.28639.2894 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109058/#review27794
-----------------------------------------------------------
There's KStandardDirs::findExe() to look through PATH: \
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html#a2cdee9ed57939256abd672bb4c6cb5cf
- Andreas Pakulat
On Feb. 20, 2013, 6:47 p.m., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109058/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 6:47 p.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Description
> -------
>
> Add gitk, qgit, git-cola to context menu of projects tree view.
>
>
> Diffs
> -----
>
> kate/plugins/project/CMakeLists.txt 9e507ce
> kate/plugins/project/kateprojecttreeviewcontextmenu.h PRE-CREATION
> kate/plugins/project/kateprojecttreeviewcontextmenu.cpp PRE-CREATION
> kate/plugins/project/kateprojectviewtree.cpp 041485b
>
> Diff: http://git.reviewboard.kde.org/r/109058/diff/
>
>
> Testing
> -------
>
> Launching the apps works. Currently QProcess is used to check, whether a binary \
> exists along with `which`. I couldn't find a KDE way.
>
> File Attachments
> ----------------
>
> Context Menu
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/20/context-menu.png
>
>
> Thanks,
>
> Dominik Haumann
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109058/">http://git.reviewboard.kde.org/r/109058/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> There's \
KStandardDirs::findExe() to look through PATH: \
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html#a2cdee9ed57939256abd672bb4c6cb5cf</pre>
<br />
<p>- Andreas</p>
<br />
<p>On February 20th, 2013, 6:47 p.m. UTC, Dominik Haumann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 6:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add gitk, qgit, git-cola to context menu of projects tree view.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching the apps works. Currently QProcess is used to check, whether a \
binary exists along with `which`. I couldn't find a KDE way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/project/CMakeLists.txt <span style="color: \
grey">(9e507ce)</span></li>
<li>kate/plugins/project/kateprojecttreeviewcontextmenu.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/plugins/project/kateprojecttreeviewcontextmenu.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kate/plugins/project/kateprojectviewtree.cpp <span style="color: \
grey">(041485b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109058/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/20/context-menu.png">Context \
Menu</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic