'Review Request 108555: Monitor symlinked files for changes while editing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request 108555: Monitor symlinked files for changes while editing
From:       "Andre Heinecke" <aheinecke () intevation ! de>
Date:       2013-01-22 17:59:56
Message-ID: 20130122175956.25924.61474 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108555/
-----------------------------------------------------------

Review request for Kate.

Description
-------

If you open a soft symlink in kate kate monitors that symlink for changes and not the \
file that the symlink points to. This can lead to data loss if someone modifies the \
linked file while kate is open because that change is not detected and the "someone \
changed the file" dialog is not shown.

This Patch uses the canonical file path to activate the dirwatch in case the file is \
a symlink

This addresses bug 149175.
    http://bugs.kde.org/show_bug.cgi?id=149175

Diffs
-----

  part/document/katedocument.cpp 649893f 

Diff: http://git.reviewboard.kde.org/r/108555/diff/

Testing
-------

Tested with a file that is a symlink and directly with a file.

Thanks,

Andre Heinecke

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108555/">http://git.reviewboard.kde.org/r/108555/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Andre Heinecke.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If you open a soft symlink in kate kate monitors that symlink for \
changes and not the file that the symlink points to. This can lead to data loss if \
someone modifies the linked file while kate is open because that change is not \
detected and the &quot;someone changed the file&quot; dialog is not shown.

This Patch uses the canonical file path to activate the dirwatch in case the file is \
a symlink</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with a file that is a symlink and directly with a file.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=149175">149175</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/document/katedocument.cpp <span style="color: grey">(649893f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108555/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 