'Review Request: Very small patch that sets minimum size of config dialog in Kate setto 680x480'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request: Very small patch that sets minimum size of config dialog in Kate setto 680x480
From:       "Mikael Hermansson" <mike () 7b4 ! se>
Date:       2012-12-26 17:39:00
Message-ID: 20121226173900.12203.20889 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107925/
-----------------------------------------------------------

Review request for Kate and Christoph Cullmann.

Description
-------

Very small patch that sets minimum size of config dialog in Kate setto 680x=
480. =

This makes it:

* Look better
* No "frustrating" user resize screen when open dialog. =

* Almost all pages needs atleast 640x480 to show all its contents.

Diffs
-----

  kate/app/kateconfigdialog.h d9ac9241b709f204e0b67923971b57176f00f40d =

  kate/app/kateconfigdialog.cpp 08945e992cbe418c2385abedb21c902b36158e57 =

Diff: http://git.reviewboard.kde.org/r/107925/diff/

Testing
-------

Tested on bigscreen 2560x1900 and small laptop screen 1380x780

Screenshots
-----------

  http://git.reviewboard.kde.org/r/107925/s/931/

Thanks,

Mikael Hermansson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107925/">http://git.reviewboard.kde.org/r/107925/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Mikael Hermansson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Very small patch that sets minimum size of config dialog in Kate setto \
680x480. 

This makes it:

* Look better
* No &quot;frustrating&quot; user resize screen when open dialog. 
* Almost all pages needs atleast 640x480 to show all its contents.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on bigscreen 2560x1900 and small laptop screen 1380x780 </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/kateconfigdialog.h <span style="color: \
grey">(d9ac9241b709f204e0b67923971b57176f00f40d)</span></li>

 <li>kate/app/kateconfigdialog.cpp <span style="color: \
grey">(08945e992cbe418c2385abedb21c902b36158e57)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107925/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/107925/s/931/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/26/bugsnapshot4_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 