[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Tidy up Python 3 support.
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2012-11-28 22:21:25
Message-ID: CAHAc2jeAMU-viPuQmkdcBPjGz5xq7jci55a3RAhmTfVy6=L=5A () mail ! gmail ! com
[Download RAW message or body]

Hi Luca,

As per the reviewboard, 3.2 links/works if I workaround the naming
convention mentioned above is worked-around. As for if this issue is
in FIndPythonLIbrary.cmake, I think that this line:

      set(PYTHON_LIBRARY_NAMES python${PYTHON_SHORT_VERSION}
python${PYTHON_SHORT_VERSION_NO_DOT})

needs extending for the naming convention UNLESS it is expected that
the distro should provide the additional link that I created by hand.
I assume the script works as-is on your distro's 3.3 system, but it
obviously does not on my Ubuntu 3.2 system.

Finally, I have not attempted to build/run against 3.3. Can you
confirm if it works for you. (Just try opening the Python Console, and
broswe the Pate plugin's config dialog).

Thanks, Shaheed

On 24 November 2012 09:12, Luca Beltrame <lbeltrame@kde.org> wrote:
> In data sabato 24 novembre 2012 00:54:32, Shaheed Haque ha scritto:
>
>> -- Found Python executable: /usr/bin/python3
>> -- Found Python version: 3.2.3
>> -- Found Python library: PYTHON_LIBRARY-NOTFOUND
>
> If you use FindPythonLIbrary, that may be as well for some of the changes I
> introduced though (however, they work for me).
> If you have time, look through the FIndPythonLIbrary.cmake module in kdelibs
> and see if there's anything fishy.
>
>> are objections, I plan to commit the code as-is, and offer support on an
>> ad-hoc basis to any brave souls who want to try to get 3.x support going.
>
> Probably yes. I suppose blogging about it may help.
>
> --
> Luca Beltrame - KDE Forums team
> KDE Science supporter
> GPG key ID: 6E1A4E79
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]