[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: Tidy up Python 3 support.
From: "Luca Beltrame" <lbeltrame () kde ! org>
Date: 2012-11-23 9:03:39
Message-ID: 20121123090339.13310.47255 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107391/#review22413
-----------------------------------------------------------
kate/plugins/pate/src/utilities.cpp
<http://git.reviewboard.kde.org/r/107391/#comment17180>
I don't know if it's treated the same way, but I wonder i we could use =
AS_DATA for everything. But that depends on the QString constructors (AS_DA=
TA gives const char*, I don't know if ::fromUtf16 and ::fromUCs4 need diffe=
rent)
- Luca Beltrame
On Nov. 22, 2012, 7:07 p.m., Shaheed Haque wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107391/
> -----------------------------------------------------------
> =
> (Updated Nov. 22, 2012, 7:07 p.m.)
> =
> =
> Review request for Kate and Luca Beltrame.
> =
> =
> Description
> -------
> =
> Tidy up Python 3 support by rationalising the #ifs contributed by Luca vi=
a https://git.reviewboard.kde.org/r/107362/
> =
> =
> Diffs
> -----
> =
> kate/plugins/pate/src/engine.cpp 487a8574ffb60eb2e846faa79cc9de529f3921=
9c =
> kate/plugins/pate/src/plugin.cpp a1dfa4843a3efa3689d1543fc72bafe46ac134=
6a =
> kate/plugins/pate/src/utilities.h 7edf71c83523354cfd5b9bda4a6d7de6e9e1c=
41d =
> kate/plugins/pate/src/utilities.cpp 20e53a3abff47d99fdf37f435a963f4d714=
f8ac5 =
> =
> Diff: http://git.reviewboard.kde.org/r/107391/diff/
> =
> =
> Testing
> -------
> =
> Compiled/tested with Python 2.
> =
> =
> Thanks,
> =
> Shaheed Haque
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107391/">http://git.reviewboard.kde.org/r/107391/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107391/diff/4/?file=95855#file95855line403" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kate/plugins/pate/src/utilities.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool Python::isUnicode(PyObject *string)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">388</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">QString</span><span class="o">::</span><span \
class="n">fromUtf16</span><span class="p">(</span><span \
class="n">PyUnicode_2BYTE_DATA</span><span class="p">(</span><span \
class="n">string</span><span class="p">),</span> <span class="n">unichars</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't \
know if it's treated the same way, but I wonder i we could use AS_DATA for \
everything. But that depends on the QString constructors (AS_DATA gives const char*, \
I don't know if ::fromUtf16 and ::fromUCs4 need different)</pre> </div>
<br />
<p>- Luca</p>
<br />
<p>On November 22nd, 2012, 7:07 p.m., Shaheed Haque wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Luca Beltrame.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 7:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tidy up Python 3 support by rationalising the #ifs contributed by Luca \
via https://git.reviewboard.kde.org/r/107362/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled/tested with Python 2.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/pate/src/engine.cpp <span style="color: \
grey">(487a8574ffb60eb2e846faa79cc9de529f39219c)</span></li>
<li>kate/plugins/pate/src/plugin.cpp <span style="color: \
grey">(a1dfa4843a3efa3689d1543fc72bafe46ac1346a)</span></li>
<li>kate/plugins/pate/src/utilities.h <span style="color: \
grey">(7edf71c83523354cfd5b9bda4a6d7de6e9e1c41d)</span></li>
<li>kate/plugins/pate/src/utilities.cpp <span style="color: \
grey">(20e53a3abff47d99fdf37f435a963f4d714f8ac5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107391/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic