'Review Request: Tidy up Python 3 support.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request: Tidy up Python 3 support.
From:       "Shaheed Haque" <srhaque () theiet ! org>
Date:       2012-11-19 21:56:14
Message-ID: 20121119215614.24609.11201 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107391/
-----------------------------------------------------------

Review request for Kate and Luca Beltrame.

Description
-------

Tidy up Python 3 support by rationalising the #ifs.

Diffs
-----

  kate/plugins/pate/src/engine.cpp 487a8574ffb60eb2e846faa79cc9de529f39219c =

  kate/plugins/pate/src/plugin.cpp a1dfa4843a3efa3689d1543fc72bafe46ac1346a =

  kate/plugins/pate/src/utilities.h 7edf71c83523354cfd5b9bda4a6d7de6e9e1c41=
d =

  kate/plugins/pate/src/utilities.cpp 20e53a3abff47d99fdf37f435a963f4d714f8=
ac5 =

Diff: http://git.reviewboard.kde.org/r/107391/diff/

Testing
-------

Compiled/tested with Python 2.

Thanks,

Shaheed Haque

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107391/">http://git.reviewboard.kde.org/r/107391/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Luca Beltrame.</div>
<div>By Shaheed Haque.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tidy up Python 3 support by rationalising the #ifs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled/tested with Python 2.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/plugins/pate/src/engine.cpp <span style="color: \
grey">(487a8574ffb60eb2e846faa79cc9de529f39219c)</span></li>

 <li>kate/plugins/pate/src/plugin.cpp <span style="color: \
grey">(a1dfa4843a3efa3689d1543fc72bafe46ac1346a)</span></li>

 <li>kate/plugins/pate/src/utilities.h <span style="color: \
grey">(7edf71c83523354cfd5b9bda4a6d7de6e9e1c41d)</span></li>

 <li>kate/plugins/pate/src/utilities.cpp <span style="color: \
grey">(20e53a3abff47d99fdf37f435a963f4d714f8ac5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107391/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 