[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: fix runtime errors in "default" Pate's expand.py
From: Shaheed Haque <srhaque () theiet ! org>
Date: 2012-06-15 19:55:03
Message-ID: CAHAc2jfKvcGrGo4-UTUS-Z6Pct9=KmCu_eATe0jTy38XxL_N9w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Fair enough. Ship it.
On 15 June 2012 14:34, Alex Turbov <i.zaufi@gmail.com> wrote:
> I'm about this:
>
>
> >>> d = kate.activeDocument().smartInterface()
> >>> type(d)
>
> <type 'NoneType'>
>
> so, pate's cursor positioning actually doesn't works
>
>
>
> On Fri, Jun 15, 2012 at 5:28 PM, Shaheed Haque <srhaque@theiet.org> wrote:
>
>> Hi Alex,
>>
>> Are you sure about the smartInterface? This is what I see:
>>
>> >>> dir (kate.activeDocument().smartInterface())
>>
>> ['__class__', '__delattr__', '__doc__', '__format__', '__getattribute__',
>> '__hash__', '__init__', '__new__', '__reduce__', '__reduce_ex__',
>> '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__']
>>
>>
>> I have the impression that the existing APIs might be a little
>> inconsistent; I've not looked too closely, not wanting to
>> break compatibility being one reason, but maybe it is worth thinking about
>> as I have a half-eye on the need to document the APIs as we move into the
>> main product. Comments welcome.
>>
>> On 15 June 2012 11:43, Alex Turbov <i.zaufi@gmail.com> wrote:
>>
>>> I have another patch also (see attach), but unable to create a review
>>> request for it :(
>>> a UI gives me an error:
>>> "The file 'playground/pate/src/plugins/expand/expand.py' (rf1a5dbe)
>>> could not be found in the repository"
>>>
>>> "default" Pate's expand also have another bug (unable to set cursor
>>> position, cuz document have no smart interface).
>>> this patch set the cursor position manually (cuz movingInterface isn't
>>> available yet for python) and uses '%{cursor}' (just like kate snippets
>>> plugin) instead of uncertain '\1' in templates.
>>>
>>>
>>>
>>>
>>> On Fri, Jun 15, 2012 at 2:26 PM, Alex Turbov <i.zaufi@gmail.com> wrote:
>>>
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> http://git.reviewboard.kde.org/r/105256/
>>>> Review request for Kate.
>>>> By Alex Turbov.
>>>> Description
>>>>
>>>> unicode() isn't required for current PyQt4/PyKDE4 and leads to runtime errors...
>>>>
>>>> Testing
>>>>
>>>> $ qlist -Iv kate PyQt4 pykde4 dev-lang/python:2.7
>>>> dev-lang/python-2.7.2-r3
>>>> dev-python/PyQt4-4.9.1
>>>> kde-base/kate-4.8.3
>>>> kde-base/katepart-4.8.3
>>>> kde-base/pykde4-4.8.3
>>>>
>>>> Diffs
>>>>
>>>> - playground/pate/src/plugins/expand/expand.py (6b13f49)
>>>>
>>>> View Diff <http://git.reviewboard.kde.org/r/105256/diff/>
>>>>
>>>
>>>
>>> _______________________________________________
>>> KWrite-Devel mailing list
>>> KWrite-Devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>>
>>>
>>
>> _______________________________________________
>> KWrite-Devel mailing list
>> KWrite-Devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>
>>
>
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
>
>
[Attachment #5 (text/html)]
Fair enough. Ship it.<br><br><div class="gmail_quote">On 15 June 2012 14:34, Alex \
Turbov <span dir="ltr"><<a href="mailto:i.zaufi@gmail.com" \
target="_blank">i.zaufi@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<p style="margin:0px;text-indent:0px">I'm about this:</p><p \
style="margin:0px;text-indent:0px"><br></p><p \
style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px">>>> \
d = kate.activeDocument().smartInterface()</p>
>>> type(d)
<p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px"><type \
'NoneType'></p><br>so, pate's cursor positioning actually doesn't \
works<div class="HOEnZb"><div class="h5"> <br><br><br><div class="gmail_quote">
On Fri, Jun 15, 2012 at 5:28 PM, Shaheed Haque <span dir="ltr"><<a \
href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">
Hi Alex,<div><br></div><div>Are you sure about the smartInterface? This is what I \
see:</div><div><br></div><div> <p \
style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px">>>> \
dir (kate.activeDocument().smartInterface())</p> <p \
style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px">['__class__', \
'__delattr__', '__doc__', '__format__', \
'__getattribute__', '__hash__', '__init__', \
'__new__', '__reduce__', '__reduce_ex__', '__repr__', \
'__setattr__', '__sizeof__', '__str__', \
'__subclasshook__']</p>
<p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px"><br></p><p \
style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px">I have the \
impression that the existing APIs might be a little inconsistent; I've not looked \
too closely, not wanting to break compatibility being one reason, but maybe it is \
worth thinking about as I have a half-eye on the need to document the APIs as we move \
into the main product. Comments welcome.</p>
<br><div class="gmail_quote"><div><div>On 15 June 2012 11:43, Alex Turbov <span \
dir="ltr"><<a href="mailto:i.zaufi@gmail.com" \
target="_blank">i.zaufi@gmail.com</a>></span> wrote:<br></div></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div><div>
I have another patch also (see attach), but unable to create a review request for it \
:(<br>a UI gives me an error:<br>"The file \
'playground/pate/src/plugins/expand/expand.py' (rf1a5dbe) could not be found \
in the repository"<br>
<br>"default" Pate's expand also have another bug (unable to set cursor \
position, cuz document have no smart interface).<br>this patch set the cursor \
position manually (cuz movingInterface isn't available yet for python) and uses \
'%{cursor}' (just like kate snippets plugin) instead of uncertain \
'\1' in templates.<div>
<div><br>
<br><br><br><div class="gmail_quote">On Fri, Jun 15, 2012 at 2:26 PM, Alex Turbov \
<span dir="ltr"><<a href="mailto:i.zaufi@gmail.com" \
target="_blank">i.zaufi@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105256/" \
target="_blank">http://git.reviewboard.kde.org/r/105256/</a> </td>
</tr>
</tbody></table>
<br>
<table style="background-image:url('');background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%"> \
<tbody><tr> <td>
<div>Review request for Kate.</div>
<div>By Alex Turbov.</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">unicode() \
isn't required for current PyQt4/PyKDE4 and leads to runtime errors...</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">$ \
qlist -Iv kate PyQt4 pykde4 dev-lang/python:2.7 dev-lang/python-2.7.2-r3
dev-python/PyQt4-4.9.1
kde-base/kate-4.8.3
kde-base/katepart-4.8.3
kde-base/pykde4-4.8.3</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>playground/pate/src/plugins/expand/expand.py <span \
style="color:grey">(6b13f49)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105256/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>
</div></div><br></div></div>_______________________________________________<br>
KWrite-Devel mailing list<br>
<a href="mailto:KWrite-Devel@kde.org" target="_blank">KWrite-Devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kwrite-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kwrite-devel</a><br> \
<br></blockquote></div><br></div> \
<br>_______________________________________________<br> KWrite-Devel mailing list<br>
<a href="mailto:KWrite-Devel@kde.org" target="_blank">KWrite-Devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kwrite-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kwrite-devel</a><br> \
<br></blockquote></div><br> \
</div></div><br>_______________________________________________<br> KWrite-Devel \
mailing list<br> <a href="mailto:KWrite-Devel@kde.org">KWrite-Devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kwrite-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kwrite-devel</a><br> \
<br></blockquote></div><br>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic