[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: bracket-matching for double quotes
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2012-06-14 17:30:38
Message-ID: 1738534.q2JpiV6qXM () eriador
[Download RAW message or body]

A simple fix is to remove the '"' again from the bracket matching list. I'd be 
fine with that for KDE 4.9, given that this feature was never present before.

Objections?

On Wednesday, 23. May 2012 21:59:13 Milian Wolff wrote:
> *ping*
> 
> please, I'd like to fix this issue
> 
> On Monday 14 May 2012 15:24:01 Milian Wolff wrote:
> > On Monday 14 May 2012 15:17:30 Milian Wolff wrote:
> > > Hey there,
> > > 
> > > I notice that since eba2b66fc16a0dce186a87b6376e4750635f43a9 kate is
> > > seriously sluggish when dealing with strings at the beginning of a large
> > > file.
> > > 
> > > The reason is that it tries to find matching double quotes for bracket-
> > > highlighting, just try this e.g.:
> > > 
> > > open katedocument.cpp
> > > -> add a "foo" in a new line at the beginning of the file
> > > -> move the cursor around in this line
> > > => whenever you are next to one of the double quotes you should see a
> > > noticeable delay / sluggishness
> > > 
> > > kate assumes that " is always an opening quote (which is of course
> > > wrong,
> > > it could just as easily be the closing one...) and looks in the next
> > > line
> > > for the match or so... maybe it's also an issue with the attribute?
> > > anyhow, I'd like to remove this since it's not working anyhow...
> > > objections?
> > 
> > While we are at it:
> > 
> > Could we reduce the maxLines limit in
> > KateViewInternal::updateBracketMarks?
> > Imo 1000 or even just 500 is enough... If people write functions with such
> > huge bodies they should imo be more severly punished anyways...
> > 
> > Bye
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]