[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Pate
From:       Sune Vuorela <nospam () vuorela ! dk>
Date:       2012-06-09 12:33:43
Message-ID: slrnjt6gl7.p7v.nospam () sshway ! ssh ! pusling ! com
[Download RAW message or body]

On 2012-06-07, Dominik Haumann <dhaumann@kde.org> wrote:
> Possible solution in file playground/CMakeLists.txt:
>
> -macro_optional_add_subdirectory(pate)
>  macro_optional_add_subdirectory(scriptIDE)
> +
> +macro_optional_find_package(SIP)
> +macro_log_feature(SIP_FOUND "SIP" "Support for SIP Python bindings" "")
> +
> +macro_optional_find_package(PyQt4)
> +macro_log_feature(PYQT4_FOUND "PyQt4" "Python bindings for Qt4" "")
> +
> +macro_optional_find_package(PyKDE4)
> +macro_log_feature(PYKDE4_FOUND "PyKDE4" "Python bindings for KDE4" "")
> +
> +if (SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND)
> +  macro_optional_add_subdirectory(pate)
> +endif (SIP_FOUND AND PYQT4_FOUND AND PYKDE4_FOUND)

Hi

Please don't let 'what's being installed' depend on what's being
available in the build environment. 

Most people don't actualy run apps in the environment of where they are
being built.

The discussion have been done a couple of times on k-c-d, and the
agreement has been to do something like

if(not runtime_deps_found) 
  warn_about_it()
endif(not runtime_deps_found)

add_subdirectory(stuff)

/Sune

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]