[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Review Request: avoid 3 clang warnings
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-06-02 10:51:07
Message-ID: 20120602105107.2926.53672 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105134/
-----------------------------------------------------------
Review request for Kate.
Description
-------
Just place {} around if to avoid the compiler to choose the right level of =
else.
Use the variable newLineReg (unused ) to do the same just a little faster (=
avoid 1 QRegExpresion compilation ).
Diffs
-----
kate/plugins/katesql/dataoutputmodel.cpp 760f8bb =
part/render/katelayoutcache.cpp 2030d07 =
part/syntax/katehighlight.cpp c31c634 =
Diff: http://git.reviewboard.kde.org/r/105134/diff/
Testing
-------
works as before.
Thanks,
Jaime Torres Amate
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105134/">http://git.reviewboard.kde.org/r/105134/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Jaime Torres Amate.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just place {} around if to avoid the compiler to choose the right level \
of else. Use the variable newLineReg (unused ) to do the same just a little faster ( \
avoid 1 QRegExpresion compilation ).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as before.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/plugins/katesql/dataoutputmodel.cpp <span style="color: \
grey">(760f8bb)</span></li>
<li>part/render/katelayoutcache.cpp <span style="color: grey">(2030d07)</span></li>
<li>part/syntax/katehighlight.cpp <span style="color: grey">(c31c634)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105134/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic