[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Please check the unit tests ;)
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2011-09-29 16:44:04
Message-ID: 201109291844.05038.dhdev () gmx ! de
[Download RAW message or body]

Ok, finally back to this:

I've looked into the test case, and yes, it only fails if dynamic word wrap is 
false. Adrian, you say, the highlighting is never called in this case. Did you 
look at the code path here? If so, in which line is it going wrong?

We should find a fix for certain here, since it must be a bug.

Greetings,
Dominik

On Wednesday, August 10, 2011 01:30:52 PM Adrian Lungu wrote:
> Hi Christoph
> 
> I took a look through the test and ran it many times. I am not so sure if
> the
> problem is folded related.
> 
> view->config()->setDynWordWrap(dynWordWrap);
> 
> In this line if "dynWordWrap" is "false" then kate's hl is never called.
> Therefore
> the folding tree is not built and that's why the folding is not working.
> 
> When folding a node, KateBuffer::ensureHighlighted() is called for the
> whole folded block, but here, because the hl was never called, that node
> that should
> fold doesn't exist.
> 
> I can call ensureHighlighted() for the whole doc, each time a fold is
> triggered,
> to make sure that the document was parsed and the folding tree was built,
> but
> wouldn't be a little too time consuming? Also, it is ok that kate's hl is
> never called
> when "dynWordWrap" is set "false"?
> 
> Greetings,
> Adrian
> 
> On Tue, Aug 9, 2011 at 5:11 PM, Christoph <cullmann@absint.com>wrote:
> > Hi,
> > 
> > the kateview_test seems to fail because of folding regressions/changes,
> > please take a look.
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]