'Re: Review Request: Sort items in Highlight Download dialog by name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Sort items in Highlight Download dialog by name
From:       "Joseph Wenninger" <kde () jowenn ! at>
Date:       2011-09-01 9:48:27
Message-ID: 20110901094827.8278.29488 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102499/#review6207
-----------------------------------------------------------

Ship it!

Looks fine!

- Joseph

On Aug. 31, 2011, 8:07 p.m., Christian Loose wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102499/
> -----------------------------------------------------------
> =

> (Updated Aug. 31, 2011, 8:07 p.m.)
> =

> =

> Review request for Kate.
> =

> =

> Summary
> -------
> =

> Sort items in Highlight Download dialog by name
> =

> =

> Diffs
> -----
> =

>   part/dialogs/katedialogs.cpp 882946f4b77524531db610f8475b8d80fc59cc5b =

> =

> Diff: http://git.reviewboard.kde.org/r/102499/diff
> =

> =

> Testing
> -------
> =

> See Screenshots
> =

> =

> Screenshots
> -----------
> =

> before
>   http://git.reviewboard.kde.org/r/102499/s/245/
> after
>   http://git.reviewboard.kde.org/r/102499/s/246/
> =

> =

> Thanks,
> =

> Christian
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102499/">http://git.reviewboard.kde.org/r/102499/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine!</pre>  <br \
/>

<p>- Joseph</p>

<br />
<p>On August 31st, 2011, 8:07 p.m., Christian Loose wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Christian Loose.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2011, 8:07 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sort items in Highlight Download dialog by name</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See Screenshots</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/dialogs/katedialogs.cpp <span style="color: \
grey">(882946f4b77524531db610f8475b8d80fc59cc5b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102499/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/102499/s/245/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/31/before-highlight-download_400x100.PNG" \
style="border: 1px black solid;" alt="before" /></a>

 <a href="http://git.reviewboard.kde.org/r/102499/s/246/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/31/after-highlight-download_400x100.PNG" \
style="border: 1px black solid;" alt="after" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 