'Re: Review Request: Add print() method to the documents D-Bus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Add print() method to the documents D-Bus
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-19 17:20:12
Message-ID: 20110819172012.3425.97850 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102346/#review5833
-----------------------------------------------------------

This review has been submitted with commit c72e8edae0b98c729ed1214f7752afb0c9c1e933 \
by Christian Loose to branch master.

- Commit

On Aug. 18, 2011, 8:38 p.m., Christian Loose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102346/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 8:38 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Summary
> -------
> 
> Add print() method to the documents D-Bus interface
> 
> Mark print() method in the KateDocument as Q_SCRIPTABLE and expose it
> on the D-Bus session bus.
> 
> example:
> qdbus org.kde.kate-7762 /Kate/Document/1 print
> 
> 
> This addresses bug 246440.
> http://bugs.kde.org/show_bug.cgi?id=246440
> 
> 
> Diffs
> -----
> 
> part/document/katedocument.h 42cdeb6728e19bc8029d23b7eaf19c88f7ca8b10 
> part/document/katedocument.cpp 131718c13cb90d443bc433f5074a5979a1c66aae 
> 
> Diff: http://git.reviewboard.kde.org/r/102346/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102346/">http://git.reviewboard.kde.org/r/102346/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c72e8edae0b98c729ed1214f7752afb0c9c1e933 by Christian Loose to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 18th, 2011, 8:38 p.m., Christian Loose wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Christian Loose.</div>

<p style="color: grey;"><i>Updated Aug. 18, 2011, 8:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add print() method to the documents D-Bus interface

Mark print() method in the KateDocument as Q_SCRIPTABLE and expose it
on the D-Bus session bus.

example:
qdbus org.kde.kate-7762 /Kate/Document/1 print
</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=246440">246440</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/document/katedocument.h <span style="color: \
grey">(42cdeb6728e19bc8029d23b7eaf19c88f7ca8b10)</span></li>

 <li>part/document/katedocument.cpp <span style="color: \
grey">(131718c13cb90d443bc433f5074a5979a1c66aae)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102346/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 