[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Please check the unit tests ;)
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2011-08-11 8:48:25
Message-ID: 201108111048.25507.dhdev () gmx ! de
[Download RAW message or body]

On Wednesday, August 10, 2011 05:37:42 PM Adrian Lungu wrote:
> On Wed, Aug 10, 2011 at 2:35 PM, Milian Wolff <mail@milianw.de> wrote:
> > Adrian Lungu, 10.08.2011:
> > > Hi Christoph
> > > 
> > > I took a look through the test and ran it many times. I am not so sure
> > > if the
> > > problem is folded related.
> > > 
> > > view->config()->setDynWordWrap(dynWordWrap);
> > > 
> > > In this line if "dynWordWrap" is "false" then kate's hl is never
> > > called. Therefore
> > > the folding tree is not built and that's why the folding is not
> > > working.
> > > 
> > > When folding a node, KateBuffer::ensureHighlighted() is called for the
> > > whole folded block, but here, because the hl was never called, that
> > > node that should
> > > fold doesn't exist.
> > > 
> > > I can call ensureHighlighted() for the whole doc, each time a fold is
> > > triggered,
> > > to make sure that the document was parsed and the folding tree was
> > > built, but
> > > wouldn't be a little too time consuming? Also, it is ok that kate's hl
> > > is never called
> > > when "dynWordWrap" is set "false"?
> > 
> > that sounds wrong to me - highlighting should work with dyn word wrap
> > after all...
> 
> So.. is there a bug in hl or dyn wrap? Who knows how this works and can
> take

I did not have a look. But still, can you think of a test case that does not 
work just because of this bug? We could use that as unit test to get it fixed.

Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]