[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Please check the unit tests ;)
From: Adrian Lungu <adrian.lungu89 () gmail ! com>
Date: 2011-08-10 15:37:42
Message-ID: CADFtesAE8x9GBCzTW3Z4A0TqCuCcmLfUj16E5T5pD7ri_vcMKQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Aug 10, 2011 at 2:35 PM, Milian Wolff <mail@milianw.de> wrote:
> Adrian Lungu, 10.08.2011:
> > Hi Christoph
> >
> > I took a look through the test and ran it many times. I am not so sure if
> > the
> > problem is folded related.
> >
> > view->config()->setDynWordWrap(dynWordWrap);
> >
> > In this line if "dynWordWrap" is "false" then kate's hl is never called.
> > Therefore
> > the folding tree is not built and that's why the folding is not working.
> >
> > When folding a node, KateBuffer::ensureHighlighted() is called for the
> > whole folded block, but here, because the hl was never called, that node
> > that should
> > fold doesn't exist.
> >
> > I can call ensureHighlighted() for the whole doc, each time a fold is
> > triggered,
> > to make sure that the document was parsed and the folding tree was built,
> > but
> > wouldn't be a little too time consuming? Also, it is ok that kate's hl is
> > never called
> > when "dynWordWrap" is set "false"?
>
> that sounds wrong to me - highlighting should work with dyn word wrap after
> all...
>
So.. is there a bug in hl or dyn wrap? Who knows how this works and can take
a look?
--
Adrian Lungu
Student @ Computer Science and Engineering - "Politehnica" University of
Bucharest
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Wed, Aug 10, 2011 at 2:35 PM, Milian Wolff <span \
dir="ltr"><<a href="mailto:mail@milianw.de">mail@milianw.de</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> Adrian Lungu, 10.08.2011:<br>
<div class="im">> Hi Christoph<br>
><br>
> I took a look through the test and ran it many times. I am not so sure if<br>
> the<br>
> problem is folded related.<br>
><br>
> view->config()->setDynWordWrap(dynWordWrap);<br>
><br>
> In this line if "dynWordWrap" is "false" then kate's hl \
is never called.<br> > Therefore<br>
> the folding tree is not built and that's why the folding is not working.<br>
><br>
> When folding a node, KateBuffer::ensureHighlighted() is called for the<br>
> whole folded block, but here, because the hl was never called, that node<br>
> that should<br>
> fold doesn't exist.<br>
><br>
> I can call ensureHighlighted() for the whole doc, each time a fold is<br>
> triggered,<br>
> to make sure that the document was parsed and the folding tree was built,<br>
> but<br>
> wouldn't be a little too time consuming? Also, it is ok that kate's hl \
is<br> > never called<br>
> when "dynWordWrap" is set "false"?<br>
<br>
</div>that sounds wrong to me - highlighting should work with dyn word wrap after<br>
all...<br></blockquote><div><br>So.. is there a bug in hl or dyn wrap? Who knows how \
this works and can take <br>a look?<br></div></div><br clear="all"><br>-- \
<br><div>Adrian Lungu</div>Student @ Computer Science and Engineering - \
"Politehnica" University of Bucharest<br>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic