[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Please check the unit tests ;)
From:       Adrian Lungu <adrian.lungu89 () gmail ! com>
Date:       2011-08-10 11:30:52
Message-ID: CADFtesB4zLyy34oJsoevBPi0Wy3uR8L1VJeabeUGcDxs89=6oQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Christoph

I took a look through the test and ran it many times. I am not so sure if
the
problem is folded related.

view->config()->setDynWordWrap(dynWordWrap);

In this line if "dynWordWrap" is "false" then kate's hl is never called.
Therefore
the folding tree is not built and that's why the folding is not working.

When folding a node, KateBuffer::ensureHighlighted() is called for the whole
folded block, but here, because the hl was never called, that node that
should
fold doesn't exist.

I can call ensureHighlighted() for the whole doc, each time a fold is
triggered,
to make sure that the document was parsed and the folding tree was built,
but
wouldn't be a little too time consuming? Also, it is ok that kate's hl is
never called
when "dynWordWrap" is set "false"?

Greetings,
Adrian

On Tue, Aug 9, 2011 at 5:11 PM, Christoph Cullmann <cullmann@absint.com>wrote:

> Hi,
>
> the kateview_test seems to fail because of folding regressions/changes,
> please take a look.
>
> Greetings
> Christoph
>
> --
> -------------------------------------- Christoph Cullmann ---------
> AbsInt Angewandte Informatik GmbH      Email: cullmann@AbsInt.com
> Science Park 1                         Tel:   +49-681-38360-22
> 66123 Saarbrücken                      Fax:   +49-681-38360-20
> GERMANY                                WWW:   http://www.AbsInt.com
> --------------------------------------------------------------------
> Geschäftsführung: Dr.-Ing. Christian Ferdinand
> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
>



-- 
Adrian Lungu
Student @ Computer Science and Engineering - "Politehnica" University of
Bucharest

[Attachment #5 (text/html)]

Hi Christoph<br><br>I took a look through the test and ran it many times. I am not so \
sure if the <br>problem is folded \
related.<br><br>view-&gt;config()-&gt;setDynWordWrap(dynWordWrap);<br><br>In this \
line if &quot;dynWordWrap&quot; is &quot;false&quot; then kate&#39;s hl is never \
called. Therefore <br> the folding tree is not built and that&#39;s why the folding \
is not working.<br><br>When folding a node, KateBuffer::ensureHighlighted() is called \
for the whole<br>folded block, but here, because the hl was never called, that node \
that should<br>

fold doesn&#39;t exist.<br><br>I can call ensureHighlighted() for the whole doc, each \
time a fold is triggered,<br>to make sure that the document was parsed and the \
folding tree was built, but<br>wouldn&#39;t be a little too time consuming? Also, it \
is ok that kate&#39;s hl is never called<br>

when &quot;dynWordWrap&quot; is set \
&quot;false&quot;?<br><br>Greetings,<br>Adrian<br><br>

<div class="gmail_quote">On Tue, Aug 9, 2011 at 5:11 PM, Christoph Cullmann <span \
dir="ltr">&lt;<a href="mailto:cullmann@absint.com" \
target="_blank">cullmann@absint.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, \
204, 204);padding-left:1ex">



Hi,<br>
<br>
the kateview_test seems to fail because of folding regressions/changes, please take a \
look.<br> <br>
Greetings<br>
Christoph<br>
<br>
--<br>
<font color="#888888">-------------------------------------- Christoph Cullmann \
---------<br> AbsInt Angewandte Informatik GmbH      Email: cullmann@AbsInt.com<br>
Science Park 1                         Tel:   <a href="tel:%2B49-681-38360-22" \
value="+496813836022" target="_blank">+49-681-38360-22</a><br> 66123 Saarbrücken      \
Fax:   <a href="tel:%2B49-681-38360-20" value="+496813836020" \
target="_blank">+49-681-38360-20</a><br> GERMANY                                WWW:  \
                <a href="http://www.AbsInt.com" \
                target="_blank">http://www.AbsInt.com</a><br>
--------------------------------------------------------------------<br>
Geschäftsführung: Dr.-Ing. Christian Ferdinand<br>
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234<br>
</font></blockquote></div><br><br clear="all"><br>-- <br><div>Adrian \
Lungu</div>Student @ Computer Science and Engineering - &quot;Politehnica&quot; \
University of Bucharest<br>



_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]