[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request: Fix wording of a checkbox label
From: "Frederik Schwarzer" <schwarzerf () gmail ! com>
Date: 2011-02-19 1:54:06
Message-ID: 20110219015406.23063.17099 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 18, 2011, 12:18 p.m., Milian Wolff wrote:
> > fine with me, thanks
Ok, committed.
- Frederik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100676/#review1483
-----------------------------------------------------------
On Feb. 17, 2011, 11:53 p.m., Frederik Schwarzer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100676/
> -----------------------------------------------------------
> =
> (Updated Feb. 17, 2011, 11:53 p.m.)
> =
> =
> Review request for Kate.
> =
> =
> Summary
> -------
> =
> Checkbox labels are usually in the form of "Do this" (e.g. Enable spell c=
hecking) and not "This is done" (e.g. Spell checking enabled).
> =
> =
> Diffs
> -----
> =
> part/dialogs/completionconfigtab.ui 01418e7 =
> =
> Diff: http://git.reviewboard.kde.org/r/100676/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Frederik
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100676/">http://git.reviewboard.kde.org/r/100676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 18th, 2011, 12:18 p.m., <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fine with me, thanks</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, committed.</pre> <br \
/>
<p>- Frederik</p>
<br />
<p>On February 17th, 2011, 11:53 p.m., Frederik Schwarzer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Frederik Schwarzer.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2011, 11:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checkbox labels are usually in the form of "Do this" (e.g. \
Enable spell checking) and not "This is done" (e.g. Spell checking \
enabled).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/dialogs/completionconfigtab.ui <span style="color: \
grey">(01418e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100676/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic