[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: KDE/kdelibs/kate/view
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-12-03 21:24:35
Message-ID: 201012032224.39113.mail () milianw ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 03 December 2010 21:57:18 Pascal Létourneau wrote:
> On December 3, 2010 05:41:43 Milian Wolff wrote:
> > I still don't get why m_minLinesVisible is related to scrollPastEnd...
> 
> I scroll past the end when typing new text at end of a document, so it's
> convenient to respect m_minLinesVisible
> 
> I guess you want this:
> 
>     if (m_view->config()->scrollPastEnd())
>       m_cachedMaxStartPos = viewLineOffset(end, --->0<---);
>     else
>       m_cachedMaxStartPos = viewLineOffset(end, -(linesDisplayed() - 1));
> 
> I prefer the current behavior
> 
> > The offset = 0 case should still be discussed / handled in viewLineOffset
> > though.
> 
> I disagree
> If the cache is valid, all value of offset are ok
> If the cache is invalid, any value of offset can possibly trigger the
> assert (thisLine.virtualLine() == virtualCursor.line())

Ah, now that makes sense, thanks for clarifying it. I'll try to add comments 
that explain this.

Bye
-- 
Milian Wolff
mail@milianw.de
http://milianw.de

["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]