[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: (bug 239077) delay trailing-space-removal until
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2010-07-23 16:14:23
Message-ID: i2cf50$3ii$1 () dough ! gmane ! org
[Download RAW message or body]

Christoph Cullmann wrote:
> On Thursday, July 22, 2010 08:33:59 pm Matthew Woehlke wrote:
>> Matthew Woehlke wrote:
>>> http://reviewboard.kde.org/r/4456/
>>>
>>> Move removal of trailing spaces from KateTextBuffer::load to
>>> KateDocument::openFile, after config and variable parsing (which might
>>> tell us not to remove trailing space!) has been performed. Note that the
>>> removal also now goes into the undo stack; a document that has had
>>> removal performed has an undo that can undo the removal and is
>>> considered modified. (IMHO this is a good thing, but I wouldn't object
>>> to a modification to suppress undo for the on-load removal. I didn't
>>> investigate how to do that, however.)
>>>
>>> This addresses bug 239077.
>>>
>>>       https://bugs.kde.org/show_bug.cgi?id=239077
>>>
>>> Diff: http://reviewboard.kde.org/r/4456/diff
>>
>> Ping? This has sat around quite some time. If there is no comment within
>> the next week, I think I am going to commit this.
> Could live with that change, perhaps it is even more intuitive that the file is
> marked modified as it will be altered on save, as the spaces vanish.

Yes, that was my thought also, though I see I didn't say /why/, as you 
did :-).

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
ENOWIT: .sig file temporarily unavailable

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]