'Re: Find/Replace in all open files (was: Re: Sponsoring offer)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Find/Replace in all open files (was: Re: Sponsoring offer)
From:       Andras Varga <avarga71 () gmail ! com>
Date:       2010-04-28 18:48:20
Message-ID: x2o459666cb1004281148h42c1a439t7729623a3f9c8ffe () mail ! gmail ! com
[Download RAW message or body]

Hi,

I have previously offered a donation to the KDE project in case the
"Find/replace in all open files" feature (bug #156099 and many
duplicates) gets implemented in Kate.

This is a very crucial feature to me, and thus, I would like to double
my future donation, to 400 USD.

I'm really looking forward to being able to use this feature after a
"sudo apt-get install kate". Keep up the good work, Andrius!

Best,
Andras

On Wed, Apr 21, 2010 at 5:13 AM, Andrius da Costa Ribas
<andriusmao@gmail.com> wrote:
> Just changing the title of the thread to one that does not look like spam :)
> original topic: http://lists.kde.org/?t=126747124200009&r=1&w=2
>
> 2010/4/18 Andrius da Costa Ribas <andriusmao@gmail.com>
>>
>> Hi All,
>> I'm still trying to implement these changes (current changes patches
>> attached - still incomplete), however I have a few questions for the more
>> experienced people :)
>> - Is there a better way to loop through opened documents? (i.e.: move to
>> next/previous documents?)
>> - The current place where kate enables "multiple files" in the patch is
>> absolutely not the best one ( there must be a search dialog already opened,
>> then opening a new file to it work in the way it is currently in the patch)
>> any suggestions to a better place for <connect(this,
>> SIGNAL(viewEnableMultipleFileSearch (bool)), view,
>> SIGNAL(allowMultipleFileSearch(bool)));
>> emit viewEnableMultipleFileSearch(true);> ?
>> - the <connect(view, SIGNAL(searchReachedBottom()), this,
>> SLOT(searchNextDoc()));
>> connect(view, SIGNAL(searchReachedTop()), this, SLOT(searchPrevDoc()));>
>> are being cumulative, I'm not sure about an way to connect these in a single
>> view and disconnect them in the other views. (Some intermediary slot!?)
>>
>> Thanks in advance,
>> Andrius.
>> 2010/4/11 Andras Varga <avarga71@gmail.com>
>>>
>>> Hi Andrius,
>>>
>>> Yes the search functionality is inside katepart, while only kate (the
>>> app) knows the list of open buffers. I think kate and katepart have to
>>> cooperate for this feature.
>>>
>>> The way I envisioned this find/replace-in-all-open-files feature to
>>> work is this (I have to say up front that I'm an experienced C++
>>> programmer but only have superficial developer knowledge about KDE or
>>> Qt):
>>> - within one buffer, find/replace would work as it does now (inside
>>> katepart)
>>> - when find/replace reaches the end of the buffer, kate (the app)
>>> would be notified somehow (signals/slots? callback? other kate or kde
>>> devs should know it)
>>> - when the app gets this notification, it would flip to the next
>>> buffer and initiate find/replace in it, taking the search and
>>> replacement strings, case sensitive/whole words/regex etc options from
>>> the previous buffer
>>> - the app would of course stop when it has visited all buffers and got
>>> back to the initial one
>>>
>>> There are some additional items to tackle, such as the "[ ] in all
>>> open files" checkbox in the find/replace panel should be optional; it
>>> only needs to be shown in multi-buffer apps like kate, and it is not
>>> needed e.g. in kwrite. So, katepart should have some
>>> setShowFindInAllBuffersCheckbox(bool) method(?). I'm not sure how to
>>> best implement optional widgets in KDE; the find/replace panel is part
>>> of katepart and it is defined in XML; perhaps there is a way to make
>>> the checkbox conditional in the XML, or maybe the checkbox itself
>>> would always exist but be hidden (via C++ code) if it does not need to
>>> be shown.
>>>
>>> Hope this helps a bit
>>>
>>> Andras
>>>
>>>
>>>
>>> On Sun, Apr 11, 2010 at 11:24 PM, Andrius da Costa Ribas
>>> <andriusmao@gmail.com> wrote:
>>> > Hi All,
>>> > I took a look at the code these two last weekends and had seen that the
>>> > search funcionality resides under kdelibs, being used not only in kate
>>> > but
>>> > in everything that may use katepart, this means that single document
>>> > apps
>>> > like kwrite use it, currently I don't know how to determine if the app
>>> > is
>>> > single or multiple document to enable/disable looping through the
>>> > documents
>>> > ( and how to get a list of opened documents ).
>>> > Most editors have an option to search in opened files inside the
>>> > "find-in-files" operation, I took a look there too, however the
>>> > currently
>>> > listing of "find-in-files" keeps reference to files, what happens then
>>> > if
>>> > the search is in an opened document that's not a not saved file (i.e.:
>>> > one
>>> > or more new documents inside kate)!?
>>> > I'm not an experienced developer, so maybe others in the list have some
>>> > clarification about that :)
>>> > Thanks,
>>> > Andrius.
>>> >
>>> >
>>> > 2010/3/29 Andras Varga <avarga71@gmail.com>
>>> >>
>>> >> Hi Andrius,
>>> >>
>>> >> I saw that your patch has already been reviewed and accepted. Great
>>> >> job, thanks a lot!!! I just made the donation of 75 EUR (~100 USD) to
>>> >> KDE, I guess it should appear at
>>> >> http://www.kde.org/community/donations/previousdonations.php soon. Too
>>> >> bad there wasn't any "comments" or "message" field in the form, I
>>> >> would've put your name in it :)
>>> >>
>>> >> Looking forward to seeing to the other feature, "find/replace in all
>>> >> open files" get implemented as well! ;)
>>> >>
>>> >> Cheers
>>> >> Andras
>>> >>
>>> >>
>>> >> On Sun, Mar 28, 2010 at 5:37 PM, Andrius da Costa Ribas
>>> >> <andriusmao@gmail.com> wrote:
>>> >> > Hi, just sent a review request with the patch
>>> >> > <http://reviewboard.kde.org/r/3416/>.
>>> >> >
>>> >> > 2010/3/26 Andrius da Costa Ribas <andriusmao@gmail.com>
>>> >> >>
>>> >> >> Hi,
>>> >> >> I've already identified the portions of the code I'll need to
>>> >> >> change
>>> >> >> for
>>> >> >> the open all / selected feature. I needed to reinstall my linux
>>> >> >> partition
>>> >> >> and have few free time during the week but I expect to finish it
>>> >> >> during
>>> >> >> the
>>> >> >> weekend. I also develop on windows but as "activated" signal in the
>>> >> >> tree
>>> >> >> view behave different there (single/double click thing - this
>>> >> >> affects
>>> >> >> selecting items) I'll need to check on linux first.
>>> >> >> --
>>> >> >> Andrius.
>>> >> >>
>>> >> >> 2010/3/26 Andras Varga <avarga71@gmail.com>
>>> >> >>>
>>> >> >>> Hi Andrius,
>>> >> >>>
>>> >> >>> Just asking how it looks on your part. Have you looked into it
>>> >> >>> already?
>>> >> >>>
>>> >> >>> Andras
>>> >> >>>
>>> >> >>> On Wed, Mar 24, 2010 at 1:36 AM, Andrius da Costa Ribas
>>> >> >>> <andriusmao@gmail.com> wrote:
>>> >> >>> > Hi, I'm a very beginner but I'll take a look on the code by this
>>> >> >>> > week
>>> >> >>> > (On
>>> >> >>> > open all/selected part). Then I'll send a patch for review.
>>> >> >>> > p.s.: in case this is fixed I'd prefer the prize to be donated
>>> >> >>> > directly
>>> >> >>> > to
>>> >> >>> > KDE e.V.
>>> >> >>> > Regards,
>>> >> >>> > Andrius. (Xiluembo on IRC)
>>> >> >>> > 2010/3/23 Andras Varga <avarga71@gmail.com>
>>> >> >>> >>
>>> >> >>> >> Zero interest so far. Any suggestions?
>>> >> >>> >>
>>> >> >>> >> Andras
>>> >> >>> >>
>>> >> >>> >> On Mon, Mar 15, 2010 at 12:37 PM, Andras Varga
>>> >> >>> >> <avarga71@gmail.com>
>>> >> >>> >> wrote:
>>> >> >>> >> > Dominik, thanks for replying!
>>> >> >>> >> >
>>> >> >>> >> > I'm just writing to confirm that the offer still stands. To
>>> >> >>> >> > make
>>> >> >>> >> > it
>>> >> >>> >> > more concrete, I'd like to offer a prize of $300 to whoever
>>> >> >>> >> > implements
>>> >> >>> >> > it. I'd rather support KDE (and the Kate editor that I like)
>>> >> >>> >> > than
>>> >> >>> >> > buy
>>> >> >>> >> > a license for some obscure closed-source editor that has
>>> >> >>> >> > these
>>> >> >>> >> > features.
>>> >> >>> >> >
>>> >> >>> >> > Just as a reminder, it's about "find/replace in all open
>>> >> >>> >> > files"
>>> >> >>> >> > and
>>> >> >>> >> > "open all (or selected) files after a find-in-files
>>> >> >>> >> > operation".
>>> >> >>> >> > They
>>> >> >>> >> > are in the bugtracker a few times as feature wishes:
>>> >> >>> >> >
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=156099
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=173350
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=193470
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=47647
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=86312
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=76617
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=45046
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=160574
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=167006
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=78072
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=203969
>>> >> >>> >> > https://bugs.kde.org/show_bug.cgi?id=209372
>>> >> >>> >> > there are likely more duplicates...
>>> >> >>> >> >
>>> >> >>> >> > so a lot of people are going to be grateful :)
>>> >> >>> >> >
>>> >> >>> >> > "Open all/selected files" is probably not difficult.
>>> >> >>> >> > "Find/replace
>>> >> >>> >> > in
>>> >> >>> >> > all open files" looks more tricky, because find/replace is
>>> >> >>> >> > implemented
>>> >> >>> >> > within KPart, but for this feature multiple KParts have to
>>> >> >>> >> > cooperate
>>> >> >>> >> > (i.e. some coordinating code needs to go into Kate itself
>>> >> >>> >> > too).
>>> >> >>> >> >
>>> >> >>> >> > Any volunteeers?
>>> >> >>> >> >
>>> >> >>> >> > Andras
>>> >> >>> >> >
>>> >> >>> >> >
>>> >> >>> >> > On Sun, Mar 14, 2010 at 10:56 PM, Dominik Haumann
>>> >> >>> >> > <dhdev@gmx.de>
>>> >> >>> >> > wrote:
>>> >> >>> >> >> On Monday 01 March 2010, Andras Varga wrote:
>>> >> >>> >> >>> Dear all,
>>> >> >>> >> >>>
>>> >> >>> >> >>> I would like to sponsor ($$) the implementation of a
>>> >> >>> >> >>> particular
>>> >> >>> >> >>> feature (actually, two features)
>>> >> >>> >> >>> in Kate. They are:
>>> >> >>> >> >>>
>>> >> >>> >> >>> - Find/replace in all open files (all at once, or
>>> >> >>> >> >>> one-by-one)
>>> >> >>> >> >>> - Open all files (after a Find in Files operation)
>>> >> >>> >> >>>
>>> >> >>> >> >>> What would be the way to go?
>>> >> >>> >> >>>
>>> >> >>> >> >>> Thanks,
>>> >> >>> >> >>> Andras
>>> >> >>> >> >>
>>> >> >>> >> >> Is there anyone interested in implementing this?
>>> >> >>> >> >> Especially Find/replace in all open files is a
>>> >> >>> >> >> long-term-wish.
>>> >> >>> >> >> The
>>> >> >>> >> >> search
>>> >> >>> >> >> functionality is there, as far as i understand, so it's just
>>> >> >>> >> >> a
>>> >> >>> >> >> matter
>>> >> >>> >> >> of
>>> >> >>> >> >> doing this gui-wise somehow...
>>> >> >>> >> >> Open all files in Find-in-files operation is even pretty
>>> >> >>> >> >> simple
>>> >> >>> >> >> to
>>> >> >>> >> >> implement...
>>> >> >>> >> >>
>>> >> >>> >> >> Dominik
>>> >> >>> >> >> _______________________________________________
>>> >> >>> >> >> KWrite-Devel mailing list
>>> >> >>> >> >> KWrite-Devel@kde.org
>>> >> >>> >> >> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>> >> >>> >> >>
>>> >> >>> >> >
>>> >> >>> >> _______________________________________________
>>> >> >>> >> KWrite-Devel mailing list
>>> >> >>> >> KWrite-Devel@kde.org
>>> >> >>> >> https://mail.kde.org/mailman/listinfo/kwrite-devel
>>> >> >>> >
>>> >> >>> >
>>> >> >>> > _______________________________________________
>>> >> >>> > KWrite-Devel mailing list
>>> >> >>> > KWrite-Devel@kde.org
>>> >> >>> > https://mail.kde.org/mailman/listinfo/kwrite-devel
>>> >> >>> >
>>> >> >>> >
>>> >> >>
>>> >> >
>>> >> >
>>> >
>>> >
>>
>
>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 