[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: TextBuffer is not thread safe - KateDocument->text() neither
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-04-09 15:27:33
Message-ID: 201004091727.38470.mail () milianw ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Milian Wolff, 09.04.2010:
> Hey all, esp. Cullmann:
> 
> I found an easy way to trigger the assert from
> https://bugs.kde.org/show_bug.cgi?id=233823 .
> 
> I added debug output and it crashes really strangely, e.g. asserts and than
> continues to output my debug output.... You know why, right :)
> 
> The text buffer is simply not threadsafe, I mean look at it... I bet this
> is the issue :-X
> 
> Did you decide to do this on purpose to crash KDevelop, meaning: Was it
> never intended to make KateDocument threadsafe?
> 
> Bye, a very sad Milian

Here this shows perfectly the problem:

TextBuffer::line( 12 ) index: 2 block: 512 768 
TextBuffer::line( 4199 ) index: 16 block: 4096 4352 
in: 12 corrected: -500 512 256 
in: 4199 corrected: 103 4096 256 

Essentially the blockForLine is not threadsafe, it gets called twice here and 
the m_lastUsedBlock is set in the middle, jerking things up...
-- 
Milian Wolff
mail@milianw.de
http://milianw.de

["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]