[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Fix apply encoding-setting from
From:       cyberbeat () gmx ! de
Date:       2010-01-01 0:26:22
Message-ID: 20100101002622.13853.94763 () localhost
[Download RAW message or body]



> On 2009-11-26 22:54:20, Dominik Haumann wrote:
> > Please verify that the order is:
> > 1. the global configuration, i.e. settings made in the user interface
> > 2. the filetypes/modes configuration
> > 3. the The File .kateconfig file
> > 4. the modelines in the document itself
> > 
> > I have no time atm at all. Cullmann or others?
> > 
> > PS: If it works as expected that's fine. But it's not the same as a review ;)

I tested the same fix for kwrite/kde4. There it works too, but has the problem, that \
in the encoding submenu the wrong encoding is displayed although the right one is \
applied from kateconfig-file. So what has changed in kwrite/kde4?


- Cyberbeat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1915/#review3311
-----------------------------------------------------------


On 2009-10-27 23:10:23, Cyberbeat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1915/
> -----------------------------------------------------------
> 
> (Updated 2009-10-27 23:10:23)
> 
> 
> Review request for Kate and Dominik Haumann.
> 
> 
> Summary
> -------
> 
> Fix bug for loading encoding from per-directory-config, which did not work before, \
> because setting encoding requires file-reloading, which was not done. 
> What I have done:
> - read the dirconfig before loading the file, so the file has not to be loaded \
>                 twice
> - only load the dirconfig, when we are not reloading (for example triggered by \
> manual encoding change) 
> 
> This addresses bug 202409.
> https://bugs.kde.org/show_bug.cgi?id=202409
> 
> 
> Diffs
> -----
> 
> branches/KDE/3.5/kdelibs/kate/part/katedocument.cpp 1038008 
> 
> Diff: http://reviewboard.kde.org/r/1915/diff
> 
> 
> Testing
> -------
> 
> The encoding thing works for me. Perhaps somebody, who is more firm with kate-code, \
> can confirm, that the change has not unwanted side effects. 
> 
> Thanks,
> 
> Cyberbeat
> 
> 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]