[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Fix apply encoding-setting from
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2009-11-26 14:17:16
Message-ID: 20091126141716.2118.12741 () localhost
[Download RAW message or body]



> On 2009-11-26 12:18:11, Milian Wolff wrote:
> > the reordering looks imo good, but the !m_reloading check is not good imo:
> > 
> > When you have a file and create a new kateconfig file, you'll have to close and \
> > reopen the file, instead of just reloading it, for it to take effect. Since lower \
> > down the variables get read, was this check really required? If so, you'll have \
> > to find a different way.
> 
> Cyberbeat wrote:
> I think it is the only way to solve the following problem:
> When I have a file opened, and there exists a kateconfig file with a special \
> encoding, but I want to override that encoding manually by selecting another \
> encoding from the menu, a reload is triggered (I don't like this behaviour), and so \
> the readdirconfig would again be applied, so my manual encoding change would have \
> no effect. 
> Is there a way to get the information, if the reload was triggered by an \
> encoding-change? In this case, I could take that as condition. 
> For me it is not too bad having to close the editor, to have the new \
> kateconfig-file settings applied.

A user in #kate just tried the patch and it worked for him.

I'll take a look at the other issue in the feature freeze period and try to get it \
fixed reliably and commit it than (for 4.4). Note that KDE3 seems to be dead.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1915/#review3298
-----------------------------------------------------------


On 2009-10-27 23:10:23, Cyberbeat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1915/
> -----------------------------------------------------------
> 
> (Updated 2009-10-27 23:10:23)
> 
> 
> Review request for Kate and Dominik Haumann.
> 
> 
> Summary
> -------
> 
> Fix bug for loading encoding from per-directory-config, which did not work before, \
> because setting encoding requires file-reloading, which was not done. 
> What I have done:
> - read the dirconfig before loading the file, so the file has not to be loaded \
>                 twice
> - only load the dirconfig, when we are not reloading (for example triggered by \
> manual encoding change) 
> 
> This addresses bug 202409.
> https://bugs.kde.org/show_bug.cgi?id=202409
> 
> 
> Diffs
> -----
> 
> branches/KDE/3.5/kdelibs/kate/part/katedocument.cpp 1038008 
> 
> Diff: http://reviewboard.kde.org/r/1915/diff
> 
> 
> Testing
> -------
> 
> The encoding thing works for me. Perhaps somebody, who is more firm with kate-code, \
> can confirm, that the change has not unwanted side effects. 
> 
> Thanks,
> 
> Cyberbeat
> 
> 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]