[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Fix apply encoding-setting from
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2009-11-26 12:18:06
Message-ID: 20091126121806.30449.55365 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1915/#review3298
-----------------------------------------------------------


the reordering looks imo good, but the !m_reloading check is not good imo:

When you have a file and create a new kateconfig file, you'll have to close and \
reopen the file, instead of just reloading it, for it to take effect. Since lower \
down the variables get read, was this check really required? If so, you'll have to \
find a different way.

- Milian


On 2009-10-27 23:10:23, Cyberbeat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1915/
> -----------------------------------------------------------
> 
> (Updated 2009-10-27 23:10:23)
> 
> 
> Review request for Kate and Dominik Haumann.
> 
> 
> Summary
> -------
> 
> Fix bug for loading encoding from per-directory-config, which did not work before, \
> because setting encoding requires file-reloading, which was not done. 
> What I have done:
> - read the dirconfig before loading the file, so the file has not to be loaded \
>                 twice
> - only load the dirconfig, when we are not reloading (for example triggered by \
> manual encoding change) 
> 
> This addresses bug 202409.
> https://bugs.kde.org/show_bug.cgi?id=202409
> 
> 
> Diffs
> -----
> 
> branches/KDE/3.5/kdelibs/kate/part/katedocument.cpp 1038008 
> 
> Diff: http://reviewboard.kde.org/r/1915/diff
> 
> 
> Testing
> -------
> 
> The encoding thing works for me. Perhaps somebody, who is more firm with kate-code, \
> can confirm, that the change has not unwanted side effects. 
> 
> Thanks,
> 
> Cyberbeat
> 
> 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]