[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: status of search refactoring
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2009-11-02 21:21:02
Message-ID: 200911022221.02909.dhdev () gmx ! de
[Download RAW message or body]

On Monday 02 November 2009, Bernhard Beschow wrote:
> Am Samstag, 31. Oktober 2009 17:03:59 schrieb Erlend Hamberg:
> > On Saturday 31. October 2009 16.43.12 Bernhard Beschow wrote:
> > > SVN commit 1043044 by beschow:
> > >
> > > introduce "search engines" for each search mode
> >
> > Wow, huge patch.
> >
> > Could you give an overview of what this is? :-)
> 
> Well, let me provide you a short status report on the search refactoring.
> 
> In the above commit, I've just splitted KateSearch into several
>  specialized classes (via svn copy). These set of classes I refer to with
>  the buzzword "search engines". ;-) The reason is the following: Since
>  the replace bar offers four search modes via a combobox, I created a
>  search engine for each mode. After all, having one specialized class for
>  each search mode should improve maintainability.
> 
> Note, that these classes are *backend* classes and are not designed for
>  direct use. You should still access them indirectly through the
>  searchText() method of KateDocument.
> 
> I have more patches for KateSearchBar in the pipeline, but I still have
>  to tidy them up and find good commit messages. ;-) When these patches
>  are in, KateSearchBar is probably ready for the high-level search logic
>  to be factored out into its own class. This class will probably also get
>  the highlighting logic (for KateView) from KateSearchBar temporariliy,
>  which will hopefully make it usable as a high-level search interface.
> 
> More questions, wishes, comments?

Yes: Even more awesomeness :) Really cool!

Dominik
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]