[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Python syntax string highlighting fixes
From:       paul () giannaros ! org
Date:       2009-09-07 9:08:54
Message-ID: 20090907090854.23296.64926 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1513/#review2249
-----------------------------------------------------------



/trunk/KDE/kdelibs/kate/syntax/data/python.xml
<http://reviewboard.kde.org/r/1513/#comment1550>

    Will update the version. I don't think I can just make that license change, but \
then again all of katepart is released under the LGPL.



/trunk/KDE/kdelibs/kate/syntax/data/python.xml
<http://reviewboard.kde.org/r/1513/#comment1551>

    OK, will do.



/trunk/KDE/kdelibs/kate/syntax/data/python.xml
<http://reviewboard.kde.org/r/1513/#comment1537>

    Yet if they're not specified then users who do not change the colours will not \
see them highlighted. Surely the common case is the one that should be catered for? \
After all, it's not "forcing" a colour so much as suggesting one.  
    However, I don't know what the policy for specifying colours is, so if it's a \
standard Kate thing to not specify colours here then I can update it. Why is the \
option to specify a colour there if it shouldn't be used?  


- pag


On 2009-09-03 00:47:25, pag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1513/
> -----------------------------------------------------------
> 
> (Updated 2009-09-03 00:47:25)
> 
> 
> Review request for Kate.
> 
> 
> Summary
> -------
> 
> Update the Python syntax highlighting file:
> * Fully support string modifiers. Support was very weak and badly implemented \
>                 before.
> * Highlighting the leading "u" on unicode strings as part of the string
> * Makes operators bold -- currently they're plain and easily ignored.
> 
> Am I OK to commit this?
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/kate/syntax/data/python.xml 1019153 
> 
> Diff: http://reviewboard.kde.org/r/1513/diff
> 
> 
> Testing
> -------
> 
> Tested before and after against \
> http://paul.giannaros.org/stuff/test_python_syntax.py  
> 
> Screenshots
> -----------
> 
> String formatting before & after
> http://reviewboard.kde.org/r/1513/s/199/
> 
> 
> Thanks,
> 
> pag
> 
> 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]