[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request: Re-add ability to configure the toolbar of Kate's
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2009-08-18 18:57:29
Message-ID: 20090818185729.16312.71506 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1286/#review2082
-----------------------------------------------------------

Ship it!


If it works for you, please commit. I don't have the time to test it atm, but will \
have a try later once I've compiled the new sources.

- Dominik


On 2009-08-11 22:08:19, Matthew Woehlke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1286/
> -----------------------------------------------------------
> 
> (Updated 2009-08-11 22:08:19)
> 
> 
> Review request for Kate.
> 
> 
> Summary
> -------
> 
> This re-adds the ability to configure the toolbar of the Filesystem Browser plugin. \
> The config page is in its own file (not the one monolithic file as previously), and \
> the default toolbar is unchanged. (The config group name is changed to be \
> consistent with the internal Selector -> Browser renaming, so this won't reacquire \
> previous configuration; maybe we should use the old name?) 
> However the separator is missing since configuring separators is apparently not \
> trivial. It looks like maybe we should convert this to KXmlGui at some point. 
> 
> This addresses bug 200251.
> https://bugs.kde.org/show_bug.cgi?id=200251
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/CMakeLists.txt 1010165 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowser.h 1010165 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowser.cpp 1010165 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowserconfig.h PRE-CREATION 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowserconfig.cpp PRE-CREATION 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowserplugin.h 1010165 
> /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowserplugin.cpp 1010165 
> 
> Diff: http://reviewboard.kde.org/r/1286/diff
> 
> 
> Testing
> -------
> 
> built, changed the toolbar
> 
> 
> Thanks,
> 
> Matthew
> 
> 

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]