------------wHuPkjVNNcq6URVjtsqq4x
Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8
Content-Transfer-Encoding: 7bit

 From the ruby.xml syntax file:

<RegExpr attribute="Comment" String="#"  context="Comment Line"  
firstNonSpace="true"/>
<RegExpr attribute="Comment" String="(\b|\s)#"  context="General Comment"/>

The second line has caused me trouble more than once, because I had to  
make sure not to skip whitespace in other contexts, or the comments wasn't  
recognized. I can't really figure out why the '#' character must be either  
the first non-space character, or preceded by a word boundary or  
whitespace.

I want to change it to:
<RegExpr attribute="Comment" String="#"  context="General Comment"/>
or, more simplified:
<DetectChar attribute="Comment" char="#" context="General Comment"/>

With this change, I can remove several other "hacks" that exists only to  
make sure whitespace isn't discarded. It would also fix several cases  
where kate doesn't recognize valid ruby comments.

I have tried several cases in the interactive ruby console that is not  
recognized as comments in kate, because of this. These examples are all  
recognized as comments by ruby, but not kate:

   foo?#comment
   foo!#comment
   10 +#comment
   10 /#comment

This, however is not a comment, but inside a regexp. But because the  
regexp/division errors are fixed, it won't be mistaken for a comment.
   foo /#comment

My question is: Can you think of any cases where a '#' character in a  
normal code context, not preceded by a word boundary or whitespace, would  
not be recognized as a comment by ruby?


-- 
Robin Pedersen
------------wHuPkjVNNcq6URVjtsqq4x
Content-Disposition: attachment; filename=comments.diff
Content-Type: application/octet-stream; name=comments.diff
Content-Transfer-Encoding: Base64

SW5kZXg6IHN5bnRheC9kYXRhL3J1YnkueG1sCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIHN5bnRheC9kYXRhL3J1YnkueG1sCShyZXZpc2lvbiA4MTQ0MTApCisrKyBz
eW50YXgvZGF0YS9ydWJ5LnhtbAkod29ya2luZyBjb3B5KQpAQCAtMjgxLDggKzI4
MSw3IEBACiAJCQkJCiAJCQkJPFJlZ0V4cHIgYXR0cmlidXRlPSJDb21tZW50IiBT
dHJpbmc9IiNccypCRUdJTi4qJCIgIGNvbnRleHQ9IiNzdGF5IiBiZWdpblJlZ2lv
bj0ibWFya2VyIiBjb2x1bW49IjAiLz4KIAkJCQk8UmVnRXhwciBhdHRyaWJ1dGU9
IkNvbW1lbnQiIFN0cmluZz0iI1xzKkVORC4qJCIgIGNvbnRleHQ9IiNzdGF5IiBl
bmRSZWdpb249Im1hcmtlciIgY29sdW1uPSIwIi8+Ci0JCQkJPFJlZ0V4cHIgYXR0
cmlidXRlPSJDb21tZW50IiBTdHJpbmc9IiMiICBjb250ZXh0PSJDb21tZW50IExp
bmUiIGZpcnN0Tm9uU3BhY2U9InRydWUiLz4KLQkJCQk8UmVnRXhwciBhdHRyaWJ1
dGU9IkNvbW1lbnQiIFN0cmluZz0iKFxifFxzKSMiICBjb250ZXh0PSJHZW5lcmFs
IENvbW1lbnQiLz4KKwkJCQk8RGV0ZWN0Q2hhciBhdHRyaWJ1dGU9IkNvbW1lbnQi
IGNoYXI9IiMiIGNvbnRleHQ9IkdlbmVyYWwgQ29tbWVudCIvPgogCQkJCQogCQkJ
CTxEZXRlY3RDaGFyIGF0dHJpYnV0ZT0iRGVsaW1pdGVyIiBjaGFyPSJbIiAgY29u
dGV4dD0iI3N0YXkiLz4KIAkJCQk8RGV0ZWN0Q2hhciBhdHRyaWJ1dGU9IkRlbGlt
aXRlciIgY2hhcj0iXSIgIGNvbnRleHQ9ImNoZWNrX2Rpdl8xIi8+CkBAIC0zMDks
MjEgKzMwOCwxOCBAQAogCQkJCiAJCQk8IS0tIEEgc2xhc2ggaXMgYWx3YXlzIGEg
ZGl2aXNpb24gb3BlcmF0b3IsIGV2ZW4gaWYgcHJlY2VlZGVkIGJ5IHdoaXRlc3Bh
Y2UgLS0+CiAJCQk8Y29udGV4dCBuYW1lPSJjaGVja19kaXZfMSIgYXR0cmlidXRl
PSJOb3JtYWwgVGV4dCIgZmFsbHRocm91Z2g9InRydWUiIGZhbGx0aHJvdWdoQ29u
dGV4dD0iI3BvcCIgbGluZUVuZENvbnRleHQ9IiNwb3AiPgotCQkJCTxSZWdFeHBy
IFN0cmluZz0iXHMqW15ccy9dIiBsb29rQWhlYWQ9InRydWUiIGNvbnRleHQ9IiNw
b3AiLz4KIAkJCQk8UmVnRXhwciBhdHRyaWJ1dGU9Ik5vcm1hbCBUZXh0IiBTdHJp
bmc9IlxzKiIgY29udGV4dD0iI3N0YXkiLz4KIAkJCQk8RGV0ZWN0Q2hhciBhdHRy
aWJ1dGU9Ik9wZXJhdG9yIiBjaGFyPSIvIiBjb250ZXh0PSIjcG9wIi8+CiAJCQk8
L2NvbnRleHQ+CiAJCQkKIAkJCTwhLS0gU2FtZSBhcyBjaGVja19kaXZfMSwgYnV0
IHdpdGggZG91YmxlIHBvcCB0byBleGl0IHRoZSBzdXJyb3VuZGluZyBjb250ZXh0
IC0tPgogCQkJPGNvbnRleHQgbmFtZT0iY2hlY2tfZGl2XzFfcG9wIiBhdHRyaWJ1
dGU9Ik5vcm1hbCBUZXh0IiBmYWxsdGhyb3VnaD0idHJ1ZSIgZmFsbHRocm91Z2hD
b250ZXh0PSIjcG9wI3BvcCIgbGluZUVuZENvbnRleHQ9IiNwb3AjcG9wIj4KLQkJ
CQk8UmVnRXhwciBTdHJpbmc9IlxzKlteXHMvXSIgbG9va0FoZWFkPSJ0cnVlIiBj
b250ZXh0PSIjcG9wI3BvcCIvPgogCQkJCTxSZWdFeHByIGF0dHJpYnV0ZT0iTm9y
bWFsIFRleHQiIFN0cmluZz0iXHMqIiBjb250ZXh0PSIjc3RheSIvPgogCQkJCTxE
ZXRlY3RDaGFyIGF0dHJpYnV0ZT0iT3BlcmF0b3IiIGNoYXI9Ii8iIGNvbnRleHQ9
IiNwb3AjcG9wIi8+CiAJCQk8L2NvbnRleHQ+CiAKIAkJCTwhLS0gQSBzbGFzaCBp
cyBkaXZpc2lvbiBvcGVyYXRvciBpZiBpdCdzIHRoZSBmaXJzdCBjaGFyYWN0ZXIs
IG9yIGlmIHByZWNlZWRlZCBhbmQgZm9sbG93ZWQgYnkgd2hpdGVzcGFjZSAtLT4K
IAkJCTxjb250ZXh0IG5hbWU9ImNoZWNrX2Rpdl8yIiBhdHRyaWJ1dGU9Ik5vcm1h
bCBUZXh0IiBmYWxsdGhyb3VnaD0idHJ1ZSIgZmFsbHRocm91Z2hDb250ZXh0PSIj
cG9wIiBsaW5lRW5kQ29udGV4dD0iI3BvcCI+Ci0JCQkJPFJlZ0V4cHIgU3RyaW5n
PSJccypbXlxzL10iIGxvb2tBaGVhZD0idHJ1ZSIgY29udGV4dD0iI3BvcCIvPgog
CQkJCTxEZXRlY3RDaGFyIGF0dHJpYnV0ZT0iT3BlcmF0b3IiIGNoYXI9Ii8iIGNv
bnRleHQ9IiNwb3AiLz4KIAkJCQk8UmVnRXhwciBhdHRyaWJ1dGU9Ik5vcm1hbCBU
ZXh0IiBTdHJpbmc9IlxzKyIgY29udGV4dD0iY2hlY2tfZGl2XzJfaW50ZXJuYWwi
Lz4KIAkJCTwvY29udGV4dD4KQEAgLTMzNSw3ICszMzEsNiBAQAogCQkJCiAJCQk8
IS0tIFNhbWUgYXMgY2hlY2tfZGl2XzIsIGJ1dCB3aXRoIGRvdWJsZSBwb3AgdG8g
ZXhpdCB0aGUgc3Vycm91bmRpbmcgY29udGV4dCAtLT4KIAkJCTxjb250ZXh0IG5h
bWU9ImNoZWNrX2Rpdl8yX3BvcCIgYXR0cmlidXRlPSJOb3JtYWwgVGV4dCIgZmFs
bHRocm91Z2g9InRydWUiIGZhbGx0aHJvdWdoQ29udGV4dD0iI3BvcCNwb3AiIGxp
bmVFbmRDb250ZXh0PSIjcG9wI3BvcCI+Ci0JCQkJPFJlZ0V4cHIgU3RyaW5nPSJc
cypbXlxzL10iIGxvb2tBaGVhZD0idHJ1ZSIgY29udGV4dD0iI3BvcCNwb3AiLz4K
IAkJCQk8RGV0ZWN0Q2hhciBhdHRyaWJ1dGU9Ik9wZXJhdG9yIiBjaGFyPSIvIiBj
b250ZXh0PSIjcG9wI3BvcCIvPgogCQkJCTxSZWdFeHByIGF0dHJpYnV0ZT0iTm9y
bWFsIFRleHQiIFN0cmluZz0iXHMrIiBjb250ZXh0PSJjaGVja19kaXZfMl9wb3Bf
aW50ZXJuYWwiLz4KIAkJCTwvY29udGV4dD4K

------------wHuPkjVNNcq6URVjtsqq4x
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

------------wHuPkjVNNcq6URVjtsqq4x--