[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    std::cerr vs. kDebug
From:       "Robin Pedersen" <robin.pedersen () runbox ! com>
Date:       2008-05-25 8:09:39
Message-ID: op.ubpaadzlxcnvyu () lenobin
[Download RAW message or body]

std::cerr was replaced with kDebug():

------------------------------------------------------------------------
r811214 | ehamberg | 2008-05-22 18:00:10 +0200 (Thu, 22 May 2008) | 2 lines

use kDebug() instead of std::cerr. this makes it possible to turn off  
debug output.

-  std::cerr << "\033[31m";
+  kDebug() << "\033[31m";
    if(!header.isNull())
-    std::cerr << qPrintable(header) << ":\n";
+    kDebug() << qPrintable(header) << ":\n";
    if(error.isError())
-    std::cerr << qPrintable(error.toString()) << '\n';
-  std::cerr <<  
qPrintable(m_engine->uncaughtExceptionBacktrace().join("\n"));
-  std::cerr << "\033[0m" << '\n';
+    kDebug() << qPrintable(error.toString()) << '\n';
+  kDebug() <<  
qPrintable(m_engine->uncaughtExceptionBacktrace().join("\n"));
+  kDebug() << "\033[0m" << '\n';
------------------------------------------------------------------------

This should probably be changed back to std::cerr:

------------------------------------------------------------------------
r797903 | giannaros | 2008-04-17 03:06:37 +0200 (Thu, 17 Apr 2008) | 7  
lines

KateIndentScript::triggerCharacters shouldn't take a KateView parameter;
one is not needed. kDebug() should _not_ be used in
KateScript::displayBacktrace, as it means that users have no decent way
of debugging a new indent script that they're writing if they use distro
packages (and trust me, that that sucks).

-  kDebug(13050) << "\033[31m";
+  std::cerr << "\033[31m";
    if(!header.isNull())
-    kDebug(13050) << qPrintable(header) << '\n';
-  kDebug(13050) <<  
qPrintable(m_engine->uncaughtExceptionBacktrace().join("\n"));
-  kDebug(13050) << "\033[0m";
+    std::cerr << qPrintable(header) << ":\n";
+  if(error.isError())
+    std::cerr << qPrintable(error.toString()) << '\n';
+  std::cerr <<  
qPrintable(m_engine->uncaughtExceptionBacktrace().join("\n"));
+  std::cerr << "\033[0m" << '\n';
------------------------------------------------------------------------

-- 
Robin Pedersen
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]