[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: KDE/kdelibs/kate
From:       "Erlend Hamberg" <ehamberg () gmail ! com>
Date:       2008-05-23 17:38:39
Message-ID: ac30b3780805231038s2e185e6fxb28698eb589fecc0 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, May 23, 2008 at 7:05 PM, Leo Savernik <l.savernik@aon.at> wrote:

> Am Freitag, 23. Mai 2008 schrieb Erlend Hamberg:
> > SVN commit 811733 by ehamberg:
> >
> > let's not use ugly defines in all files which use kDebug, specify a
> default
> > area (13000) in CMakeLists,txt. this is used if no debug area is given to
> > kDebug calls.
> >
> [...]
> > +add_definitions ( -DKDE_DEFAULT_DEBUG_AREA=13000 )
>
> This doesn't look right. You set only one default debug area whereas the
> defines had different debug areas:
>

I discussed it with Allen Winter a bit, and he said I should just define the
generic debug area in cmakelists and then let the individual developers use
their respective debug areas by giving that as a parameter to the kDebug()
call.
I plan to go over the files with sed where it's obvious that a specific
debugging area should be used.

The #defines were a bit ugly, and it's better than before, anyway, when
debug area 0 was used all over the place. :)

-- 
Erlend Hamberg
ehamberg@gmail.com

[Attachment #5 (text/html)]

On Fri, May 23, 2008 at 7:05 PM, Leo Savernik &lt;<a \
href="mailto:l.savernik@aon.at">l.savernik@aon.at</a>&gt; wrote:<br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Am Freitag, 23. \
Mai 2008 schrieb Erlend Hamberg:<br> <div class="Ih2E3d">&gt; SVN commit 811733 by \
ehamberg:<br> &gt;<br>
&gt; let&#39;s not use ugly defines in all files which use kDebug, specify a \
default<br> &gt; area (13000) in CMakeLists,txt. this is used if no debug area is \
given to<br> &gt; kDebug calls.<br>
&gt;<br>
</div>[...]<br>
<div class="Ih2E3d">&gt; +add_definitions ( -DKDE_DEFAULT_DEBUG_AREA=13000 )<br>
<br>
</div>This doesn&#39;t look right. You set only one default debug area whereas \
the<br> defines had different debug areas:<br>
</blockquote></div><br>I discussed it with Allen Winter a bit, and he said I should \
just define the generic debug area in cmakelists and then let the individual \
developers use their respective debug areas by giving that as a parameter to the \
kDebug() call.<br> I plan to go over the files with sed where it&#39;s obvious that a \
specific debugging area should be used.<br><br>The #defines were a bit ugly, and \
it&#39;s better than before, anyway, when debug area 0 was used all over the place. \
:)<br clear="all"> <br>-- <br>Erlend Hamberg<br><a \
href="mailto:ehamberg@gmail.com">ehamberg@gmail.com</a>



_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]