[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: fixing the 'deselected-selection' render bug
From:       Mirko Stocker <me () misto ! ch>
Date:       2007-08-31 12:05:20
Message-ID: 200708311405.20681.me () misto ! ch
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Wednesday 29 August 2007 08:27:58 Hamish Rodda wrote:
> Yes, but instead of updating the whole view, you can update the needed area
> by calling:
>
>   tagRange(...);
>   updateDirty();

Like I did it in the attached patch? That doesn't work, unfortunately.. or I'm 
doing something wrong :)

Thanks

Mirko

["selection.patch" (text/x-diff)]

Index: view/kateviewinternal.cpp
===================================================================
--- view/kateviewinternal.cpp	(revision 706383)
+++ view/kateviewinternal.cpp	(working copy)
@@ -1787,13 +1787,10 @@
   }
   else if ( !m_view->config()->persistentSelection() )
   {
-    int oldSelectionStartLine = m_view->selectionRange().start().line();
-    int oldSelectionEndLine = m_view->selectionRange().end().line();
-    
+    KTextEditor::Range range = m_view->selectionRange();
     m_view->clearSelection();
-    
-    cache()->relayoutLines(oldSelectionStartLine, oldSelectionEndLine);
-    cache()->updateViewCache(startPos());
+    tagRange(range, true);
+    updateDirty();
 
     m_selectionCached = KTextEditor::Range::invalid();
   }

["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]