[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Patch for "selected item uses system background color,
From:       Mirko Stocker <me () misto ! ch>
Date:       2007-07-30 20:47:33
Message-ID: 200707302247.39768.me () misto ! ch
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 30 July 2007 22:28:19 Matthew Woehlke wrote:
> I still had problems without that, the problem is that the QTextLayout
> stuff "assumes" that the pen is set to the color for dsNormal, I figured
> out that I was seeing that even when attributes were always assigned. So
> unless we fix where the QTextLayout is created (and I'm not convinced
> that's a good idea, I'm hoping someone else will comment here) I don't
> think we can get rid of that code. Although always assigning an
> attribute is probably good because that's one less place to worry about
> the "default" corner case.

Ok, I agree with you. And it doesn't hurt anyone if we set it..

>
> > which didn't really work anyway (we only set the foreground color, not
> > the background nor selected-text-colors).
>
> I'm not sure if that's a problem, in fact I don't think it is, a pen
> does not have multiple colors (maybe the painter's brush also may need
> to be set but I don't think the selected colors are a problem). Anyway
> the painter *should* be set right anyway, the problem seemed to be that
> we changed it and then didn't restore it.

I just meant that our fix wasn't complete since the background etc. weren't 
right.. anyway, I'll commit it and then let's hope that the problem is 
finally solved :)

["signature.asc" (application/pgp-signature)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread]