--===============0683558219==
Content-Type: multipart/signed;
  boundary="nextPart3634548.XJGzS4KYQ8";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart3634548.XJGzS4KYQ8
Content-Type: multipart/mixed;
  boundary="Boundary-01=_PyYgGBx27UqHRdS"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_PyYgGBx27UqHRdS
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 26 June 2007 17:12:53 Matthew Woehlke wrote:
> Indeed. Feel free to post patches here for review, I'm happy to take a
> look at anything else you find :-). (I'm not very familiar with kate's
> highlighting code either :-).)
>
> Oh, FYI I think I figured out what the 'normal text color' problem is...
> it's actually using the color used to draw the static word wrap marker,
> and only when that's turned on (the problem doesn't appear if the static
> word wrap marker is not shown). So my guess is something is failing to
> reset the pen after drawing that, which would explain why sometimes the
> right color is used, and sometimes not.

I think I've fixed the normal color rendering, and I even know why it occur=
ed.=20
The problem happens in KateHighlighting::doHighlight. At the moment we just=
=20
return if noHl is set, but the original code used memset to clean out the=20
attributes. My patch just sets the attributes to 0 and it works again :)

I was also trying to fix the other color issues with the highlighting, but =
I=20
wasn't even able to find the code that actually draws the text with the=20
color. Can somebody help me with that? In the meantime, I'll try to fix the=
=20
color selection UI, the checkboxes are behaving quite strange there..

Regards

Mirko

--Boundary-01=_PyYgGBx27UqHRdS
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="normal_highlight.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="normal_highlight.patch"

Index: syntax/katehighlight.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- syntax/katehighlight.cpp	(revision 680489)
+++ syntax/katehighlight.cpp	(working copy)
@@ -252,8 +252,10 @@
   textLine->clearAttributes ();
=20
   // no hl set, nothing to do more than the above cleaning ;)
=2D  if (noHl)
+  if (noHl) {
+    textLine->addAttribute (0, textLine->length(), 0);
     return;
+  }
=20
   // duplicate the ctx stack, only once !
   QVector<short> ctx (prevLine->ctxArray());
Index: TODO
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- TODO	(revision 680489)
+++ TODO	(working copy)
@@ -14,8 +14,6 @@
 * color issues
   * use color roles when they become available to initialize attributes
     -> this will probably fix bug 143606
=2D  * dsNormal using very wrong color ('border background'?!) as foregroun=
d most of the time
=2D    -> by 4.0 please, this wreaks havoc on u7y/a11!!
=20
 * text painted twice after clearing a selection (see http://permalink.gman=
e.org/gmane.comp.kde.devel.kwrite/12546)
=20

--Boundary-01=_PyYgGBx27UqHRdS--

--nextPart3634548.XJGzS4KYQ8
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (GNU/Linux)

iD8DBQBGgYyU4VMHj1FGBiERAteFAJsGBFSjnY8h2ENUvkGOK+3482cM4gCfddcS
3pYnLgHhbhHwZgUkbrqai5k=
=yYRh
-----END PGP SIGNATURE-----

--nextPart3634548.XJGzS4KYQ8--

--===============0683558219==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

--===============0683558219==--