From kwrite-devel Sat Jun 23 23:46:23 2007 From: Mirko Stocker Date: Sat, 23 Jun 2007 23:46:23 +0000 To: kwrite-devel Subject: Patch for "attributes appear backwards in list" Message-Id: <200706240146.28550.me () misto ! ch> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=118264241627750 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0211679833==" --===============0211679833== Content-Type: multipart/signed; boundary="nextPart1293088.UgakJBJQ3p"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1293088.UgakJBJQ3p Content-Type: multipart/mixed; boundary="Boundary-01=_PDbfG/3DOnqcray" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_PDbfG/3DOnqcray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline My first patch :-) This fixes the problem with the backwards sorted attributes. Regards Mirko --Boundary-01=_PDbfG/3DOnqcray Content-Type: text/x-diff; charset="us-ascii"; name="attributes_backwards.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="attributes_backwards.patch" Index: kate/utils/kateschema.cpp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- kate/utils/kateschema.cpp (revision 678565) +++ kate/utils/kateschema.cpp (working copy) @@ -497,8 +497,7 @@ p.setColor( QPalette::Text, _c ); m_defaultStyles->viewport()->setPalette( p ); =20 =2D // insert the default styles backwards to get them in the right order =2D for ( int i =3D KateHlManager::self()->defaultStyles() - 1; i >=3D 0; = i-- ) + for ( int i =3D 0; i < KateHlManager::self()->defaultStyles(); i++ ) { m_defaultStyles->addItem( KateHlManager::self()->defaultStyleName(i, t= rue), l->at( i ) ); } @@ -627,10 +626,9 @@ m_styles->viewport()->setPalette( p ); =20 QHash prefixes; =2D QList::ConstIterator it =3D m_hlDict[m_sch= ema][m_hl].end(); =2D while (it !=3D m_hlDict[m_schema][m_hl].begin()) + QList::ConstIterator it =3D m_hlDict[m_schem= a][m_hl].begin(); + while (it !=3D m_hlDict[m_schema][m_hl].end()) { =2D --it; KateExtendedAttribute::Ptr itemData =3D *it; Q_ASSERT(itemData); =20 @@ -654,6 +652,7 @@ } else { m_styles->addItem( itemData->name(), l->at(itemData->defaultStyleInd= ex()), itemData ); } + ++it; } =20 m_styles->resizeColumns(); --Boundary-01=_PDbfG/3DOnqcray-- --nextPart1293088.UgakJBJQ3p Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (GNU/Linux) iD8DBQBGfbDU4VMHj1FGBiERAptmAJ0dcISmUjfeotfI66RyXh6h1ZBAFACaA7Ka figmSr32jSpjoc7J7eu4PsI= =HMfh -----END PGP SIGNATURE----- --nextPart1293088.UgakJBJQ3p-- --===============0211679833== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0211679833==--