[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Fwd: KDE/kdelibs/kate/part
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2006-11-25 0:20:38
Message-ID: 200611250120.38173.dhdev () gmx ! de
[Download RAW message or body]

On Saturday 25 November 2006 01:07, Dominik Haumann wrote:
> > SVN commit 607529 by dhaumann:
> >
> > KateView:
> >   * change selection KateSmartRange insert-behaviour to
> > KTextEditor::SmartRange::ExpandRight
>
> Just to make you all aware of this change, as it could lead to
> unpredicted behaviour. The selected range now extends itself whenever
> text is inserted at the right selection bound.
> I checked it and right now KateView does *not* emit the signal
> 'selectionChanged' anymore for selection && CTRL+D.

Thinking more about it: In 3.5 branch the KateSuperCursors were also 
automatically updated, so the missing signal selectionChanged should valid 
for persistent selection. The signal was emitted for [shift+]ctrl+d though 
for KDE <= 3.5.6, as there were the explicit calls of setSelection, which I 
guess emitted it.

I don't think investing more time into this for KDE 3.5.x (3.5.6 in 
particular) makes sense, but for KDE4 it would be nice to find a 
well-defined solution.

> How do we fix this in the right way?
>
> @Hamish: Maybe by using a SmartRangeWatcher or SmartRangeNotifier and
> then forward a signal whenever the range changes?
>
> 1am, need sleep ;)
> Dominik
>
>
> --- trunk/KDE/kdelibs/kate/part/kateview.cpp #607528:607529
> @@ -115,7 +115,7 @@
>      , m_hasWrap( false )
>      , m_startingUp (true)
>      , m_updatingDocumentConfig (false)
> -    ,
> m_selection(m_doc->smartManager()->newSmartRange(KTextEditor::Range::inva
>lid())) +    ,
> m_selection(m_doc->smartManager()->newSmartRange(KTextEditor::Range::inva
>lid(), 0L, KTextEditor::SmartRange::ExpandRight)) , blockSelect (false)
>      , m_imComposeEvent( false )
>  {
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread]