[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: kate 2.4 error in kateapp
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2005-05-01 19:34:21
Message-ID: 200505012134.21297.dhdev () gmx ! de
[Download RAW message or body]

On Saturday 30 April 2005 20:44, Dominik Haumann wrote:
> On Wednesday 27 April 2005 22:20, Christoph Cullmann wrote:
> > hi,
> > could somebody change this code in kateapp.cpp:
>
> [...]
>
> > and test if that still works? this could solve the double kate win
> > creation bug
>
> Yes, it works. Starting kate on another desktop moves the kate mainwindow
> to this desktop (as supposed). I guess we should commit this, right? Do
> we have a BR for this?
>
>
> Index: kateapp.cpp
> ===================================================================
> RCS file: /home/kde/kdebase/kate/app/kateapp.cpp,v
> retrieving revision 1.96
> diff -u -3 -p -r1.96 kateapp.cpp
> --- kateapp.cpp 22 Feb 2005 14:19:52 -0000      1.96
> +++ kateapp.cpp 30 Apr 2005 18:43:35 -0000
> @@ -247,21 +247,7 @@ int KateApp::newInstance()
>    }
>    else
>    {
> -    if (activeKateMainWindow() && KWin::windowInfo
> -           (activeKateMainWindow()->winId()).isOnCurrentDesktop())
> -    {
> -      win = activeKateMainWindow();
> -    }
> -    else
> -    {
> -      for (uint i=0; i < m_mainWindows.count(); i++)
> -      {
> -        if (KWin::windowInfo
> (m_mainWindows.at(i)->winId()).isOnCurrentDesktop())
> -        {
> -          win = m_mainWindows.at(i);
> -          break;
> -        }
> -      }
> -    }
> +    win = activeKateMainWindow();
>
>      // create window on current desktop
>      if (!win)
k, this patch does not really work, see my commit from today.

-- 
Dominik
GPG Fingerprint: AC88 49E3 D8A5 0541 5B71 AC6E 29AA 1696 FF64 EDBC
User-Agent: KMail; Desktop: KDE; OS: Gentoo/Linux; *free software*
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]