[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: File not read completely when opening?
From:       Hamish Rodda <meddie () yoyo ! its ! monash ! edu ! au>
Date:       2003-02-09 11:52:13
[Download RAW message or body]

Andras Mantia wrote:

> Andras Mantia wrote:
> 
> ...
>> According to the ReadOnlyPart code the signal is emited when the
>> openFile() returns. So if openFile() wait until the whole file is read,
>> then everything's fine. But in case we don't even need the completed(),
>> as we can just wait for openURL() to return.
>> 
> ...
> 
> The ReadOnlyPart::openURL() documentation says:
> 
> "Only reimplement openURL if you don't want synchronous network
> transparency Otherwise, reimplement openFile() only ."
> 
> And later for openFile():
> 
> "If the part uses the standard implementation of openURL(), it must
> reimplement this, to open m_file. Otherwise simply define it to { return
> false; } "
> 
> Kate uses the standard openURL() implementation, and reimplements
> openFile(). According to the above, in this case the opening should be
> done in a synchronous way.

Hmm, looks like Andras has done the real investigation :)  My patch is thus
quite hackish (didn't see these emails at the time), perhaps the other Kate
devs can enlighten us as to why the loading was async in the first place...

Cheers,
Hamish.
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]