[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    [Kwrite-devel] Re: "Close" accelerator conflict
From:       Anders Lund <anders () alweb ! dk>
Date:       2002-01-31 23:43:05
[Download RAW message or body]

On Thursday 31 January 2002 21:13, Ellis Whitehead wrote:
> Hi there,
>
> I made a committed to kdelibs/interfaces/ktexteditor/ktexteditor.cpp to
> take care of a rare bug: namely that Ctrl+O and some other actions wouldn't
> work on rare occations.  I couldn't figure out how to reproduce it
> reliably, but I was able to get a backtrace on it in gdb a couple times.
>
> But now a conflict with KStdAction::close() has become apparent in kate. 
> It's declared once in kdebase/kate/app/katemainwindow.cpp and once in
> kdelibs/kate/part/kateview.cpp.  Since the Close in the part takes
> precedence, when you use the keyboard shortcut to close the window it
> merely gets flushed.  Up until now this problem hasn't been evident because
> kateview's actions weren't actually getting connected.
>
> What should be done about this?  Should the part's action shortcuts be
> turned off again (by calling actionCollection()->accel()->setEnabled( false
> );)? But why are they there in the first place if they weren't being used? 
> Is there a way for the kate part to know that it's embedded in the kate
> app?  In this case the individual shortcut could be turnd of (by
> actionCollection()->accel()->setEnabled( "file_close", false );).

I get access errors for KShortCut:
../../../../kdelibs/kate/part/kateview.cpp: In method `void 
KateView::setupActions ()':
../../../../kdelibs/kdeui/kaction.h:484: `void KAction::setShortcut (int)' is 
protected
../../../../kdelibs/kate/part/kateview.cpp:1461: within this context


due to that. I uncommented the call from the line kateview.cpp while 
comitting, but again: I think your fix should be reverted immediately. 

-anders
> _______________________________________________
> kde-kant mailing list
> kde-kant@
> http://mail.kde.org/mailman/listinfo/kde-kant
-- 
Using konqueror for serious reading? try the rellinks plugin - available from 
http://www.alweb.dk/rellinks.html

_______________________________________________
kwrite-devel mailing list
kwrite-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]