[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    [Kwrite-devel] patch for katehighlight
From:       Anders Lund <anders () alweb ! dk>
Date:       2002-01-30 19:09:25
[Download RAW message or body]

As I got tired of the hlmanager loading wrong or no hl for files quite often, 
i fixed these issues hopefully as good as possible.

This patch has the following effects:
HlManager::nameFind() will correctly compare the full match, so that eg a .css 
file does not get c hl. I also set this to not case sensitive.
HlManager::mimeFind() now uses KMimeType::findByContent() instead of the 
depricated KMimeMagic::result(). It also correctly compares the mime types, 
and in cooperation with the changes to KateDocument::openFile() posted 
earlier this should now work.

Comment (jowenn!):

1) Wouldn't it be a good idear to add a version property to the hl xml files? 
it could be used to check if the user data was for an earlier version, and 
also for the download feature, installed/available versions would be cool 
there.
I ask because I found out that I saved some information there, and as I added 
correct mime types to the perl hl in the meantime, i discovered that those 
was not considered, but overidden by my saved data.

2) The mimetype strings has changed in KDE3, what was earlier 'x-c++-src' is 
now 'x-c++src' (dash gone) and so forth. We (you, me, someone?) should go 
over all the hl files and make sure theese data are correct according to what 
KDE3 provides (the mimetype chooser in the config dialog produces nice 
strings;).

-- 
Using konqueror for serious reading? try the rellinks plugin - available from 
http://www.alweb.dk/rellinks.html


_______________________________________________
kwrite-devel mailing list
kwrite-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]