[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwintv
Subject:    Re: [Kwintv] [PATCH] devfs support for VBI decoder plugin
From:       Richard Moore <rich () xmelegance ! org>
Date:       2004-01-14 21:07:10
Message-ID: 200401142107.10933.rich () xmelegance ! org
[Download RAW message or body]

I think this is a good start towards devfs support, but a few comments:

1. I disagree with not defaulting to /dev/vbi because (as you mention) this 
works for most people. Putting some sanity checking to see if it will work is 
a good idea however.

2. It is better to use QFile::encodeName() than local8Bit() to convert a 
QString to a filename.

3. It might be better to use the Qt classes rather than calling access 
directly. This is probably a matter of opinion though.

Cheers

Rich.

_______________________________________________
kwintv mailing list
kwintv@kde.org
https://mail.kde.org/mailman/listinfo/kwintv
[prev in list] [next in list] [prev in thread] [next in thread]