[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D20890: Close screen grabbing effect when screensaver starts
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2019-04-29 8:44:31
Message-ID: 6c2a14ec63573b36ec94cfc72e7df6dc () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The screenlock fails on X11 if it can't grab the keyboard.
  
  We can't nicely solve the generic case. We can solve the common case of
  a kwin effect being active.
  
  It's not critical, arguably not even desirable to have these effects
  persist after the screen is locked through an external trigger. We can
  just close the effect early.
  
  Key grabs have to be relased early before the close animation completes
  so that the locker doesn't have a race based on animation times.
  
  It's not ideal, but no worse than the current state for not much work.
  
  BUG: 234153

TEST PLAN
  locked screen on a timer
  opened various effects

REPOSITORY
  R108 KWin

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20890

AFFECTED FILES
  CMakeLists.txt
  effects.cpp
  effects/cube/cube.cpp
  effects/desktopgrid/desktopgrid.cpp
  effects/flipswitch/flipswitch.cpp
  effects/presentwindows/presentwindows.cpp
  libkwineffects/kwineffects.h
  screenlockerwatcher.cpp
  screenlockerwatcher.h

To: davidedmundson, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, \
ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: KWin.<br />Herald added a project: KWin.<br />Herald added a \
subscriber: kwin.<br />davidedmundson requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20890">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
screenlock fails on X11 if it can&#039;t grab the keyboard.</p>

<p>We can&#039;t nicely solve the generic case. We can solve the common case of<br />
a kwin effect being active.</p>

<p>It&#039;s not critical, arguably not even desirable to have these effects<br />
persist after the screen is locked through an external trigger. We can<br />
just close the effect early.</p>

<p>Key grabs have to be relased early before the close animation completes<br />
so that the locker doesn&#039;t have a race based on animation times.</p>

<p>It&#039;s not ideal, but no worse than the current state for not much work.</p>

<p>BUG: 234153</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>locked \
screen on a timer<br /> opened various effects</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>origin-master (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D20890">https://phabricator.kde.org/D20890</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> effects.cpp<br \
/> effects/cube/cube.cpp<br />
effects/desktopgrid/desktopgrid.cpp<br />
effects/flipswitch/flipswitch.cpp<br />
effects/presentwindows/presentwindows.cpp<br />
libkwineffects/kwineffects.h<br />
screenlockerwatcher.cpp<br />
screenlockerwatcher.h</div></div></div><br /><div><strong>To: \
</strong>davidedmundson, KWin<br /><strong>Cc: </strong>kwin, jraleigh, GB_2, \
mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, \
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]